Re: [PATCH rdma-next V2 6/6] RDMA/core: Unify style of IOCTL commands

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Thu, Sep 01, 2016 at 05:17:26PM +0000, Dalessandro, Dennis wrote:
> On Thu, 2016-09-01 at 11:11 -0600, Jason Gunthorpe wrote:
> > On Thu, Sep 01, 2016 at 05:09:31PM +0000, Dalessandro, Dennis wrote:
> > 
> > > > Dennis should use an internal definition in PSM if he wishes to
> > > > continue to support the staging kernel ABI.
> > > 
> > > It's not just the backward compatibility. PSM uses these command
> > > definitions.So this breaks current support with current driver.
> > 
> > How exactly? The HFI1_CMD_ASSIGN_CTXT constant is never used in the
> > kernel?
> 
> This is used in PSM library. Agree it's not used in the kernel, so I
> can see the argument to get rid of it, or not care.

Lets get rid of all the #defines. Leon you should just inline the
ioctl numbers into the ioctl definition like normal and get rid of
this extra layer of macros.

This way Dennis will get a build failure when PSM is build with these
headers instead of subtle runtime breakage. He can import the required
definitions to support the staging compat ABI into PSM, where they
belong, and make a new release to build with new kernel headers. Lots
of time to do that before these headers hit the distros.

Upstream is not the place to carry that stuff, and keeping strange
subtleness with __NUM is just going to risk future breakage.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html