Re: [PATCH rdma-next V2 6/6] RDMA/core: Unify style of IOCTL commands

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]

On Thu, Sep 01, 2016 at 11:33:20AM -0600, Jason Gunthorpe wrote:
> On Thu, Sep 01, 2016 at 05:17:26PM +0000, Dalessandro, Dennis wrote:
> > On Thu, 2016-09-01 at 11:11 -0600, Jason Gunthorpe wrote:
> > > On Thu, Sep 01, 2016 at 05:09:31PM +0000, Dalessandro, Dennis wrote:
> > >
> > > > > Dennis should use an internal definition in PSM if he wishes to
> > > > > continue to support the staging kernel ABI.
> > > >
> > > > It's not just the backward compatibility. PSM uses these command
> > > > definitions.So this breaks current support with current driver.
> > >
> > > How exactly? The HFI1_CMD_ASSIGN_CTXT constant is never used in the
> > > kernel?
> >
> > This is used in PSM library. Agree it's not used in the kernel, so I
> > can see the argument to get rid of it, or not care.
>
> Lets get rid of all the #defines. Leon you should just inline the
> ioctl numbers into the ioctl definition like normal and get rid of
> this extra layer of macros.

Ohh, it looks like you returned to us filled with positive energy :)

I tried to follow DRM subsystem [1] while converted these names with
minimal impact on the current implementation.


> This way Dennis will get a build failure when PSM is build with these
> headers instead of subtle runtime breakage. He can import the required
> definitions to support the staging compat ABI into PSM, where they
> belong, and make a new release to build with new kernel headers. Lots
> of time to do that before these headers hit the distros.
>
> Upstream is not the place to carry that stuff, and keeping strange
> subtleness with __NUM is just going to risk future breakage.

I would love to go in this direction, to get rid of unused defines
(especially in UAPIs).

Let's wait till Sunday, maybe we will see more discussions on the topic.

[1] http://lxr.free-electrons.com/source/include/uapi/drm/i915_drm.h

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]