From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Devesh Sharma
<Devesh.sharma-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Hal Rosenstock
<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
Mike Marciniszyn
<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Tatyana Nikolova
<Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Vladimir Sokolovsky
<vlad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Lameter
<christoph-zt5rKe7wo/JBDgjK7y7TUQ@public.gmane.org>,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: RFCv3: Consolidated userspace RDMA library repo
Date: Tue, 6 Sep 2016 22:09:25 -0600 [thread overview]
Message-ID: <20160907040925.GA27361@obsidianresearch.com> (raw)
Hello Everyone,
I've updated the repo, and I think we are now at the point to begin to
engage the distribution packagers and collect their feedback. As Doug
has suggested, there are many modifications that the distros have done
that could be folded back upstream.
It is available at:
https://github.com/jgunthorpe/rdma-plumbing
Prior posts on this topic are still informative:
http://www.spinics.net/lists/linux-rdma/msg39026.html
http://www.spinics.net/lists/linux-rdma/msg39328.html
http://www.spinics.net/lists/linux-rdma/msg40014.html
The patch series has several notable improvements since last time,
based on feedback:
- If valgrind headers are available they are used by default
- Static libraries are not built by default
- If libnl is not present cmake fails by default
- NDEBUG is on for Release builds but off for RelWithDebInfo (default)
builds
- -fno-strict-aliasing is copied from upstream and applied minimally
- srptools and iwpmd are included
- Further build integration, removal of dead #ifdefs
- Warning free build on new compilers
- Start on stripping out the -abi.h mess
- Demo rpm spec file that runs on OpenSuSE 13.2/14.1/tumbleweed, FC24,
CentOS6/7 and maybe others.
The big set piece of this update is to make the compile warning-free
with "-Wall -Wextra -Wno-sign-compare -Wno-unused-parameter" on gcc
and clang.
This is a fairly high warning level and actually found some very
intersting things, my earlier patch series encompasses this stuff.
One area that needs some feedback is how far back should we bother to
support warning-free compile with gcc. Currently only gcc 6.1and clang
3.8 are warning free.
This is mainly to do with -Wmaybe-uninitialized on older compilers
that lack the static analysis that gcc now has. I know Linus has
in-the-past come out against uninitialized_var,
(https://lkml.org/lkml/2012/10/26/508) and indeed gcc 6.1 noticed one
probable-bug in mlx5 being suppressed by using this inappropriately.
Some options:
- Have cmake set -Wno-maybe-uninitialized on old compiles and forget
about it
- Annotate in zero initializers in the few places, maybe with some
kind of macro
- Leave it as is, recommend developers use gcc 6.1 or clang 3.8
Since clang throws a hissy fit with the x=x construction I've deleted
it from the tree..
For this update I am going to not post patches again, the series is
now up to 57 commits and that is too many for the mailing list.
This next major step will be to track down the packagers in distros
and inform them of the plan to collect feedback.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2016-09-07 4:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 4:09 Jason Gunthorpe [this message]
[not found] ` <20160907040925.GA27361-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-07 6:25 ` RFCv3: Consolidated userspace RDMA library repo Leon Romanovsky
[not found] ` <20160907062508.GA3639-2ukJVAZIZ/Y@public.gmane.org>
2016-09-07 15:45 ` Jason Gunthorpe
[not found] ` <20160907154508.GA2878-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-08 5:49 ` Leon Romanovsky
2016-09-08 11:26 ` Hal Rosenstock
[not found] ` <2e2b54f5-1a9d-bb31-ffd9-fe6936011aaf-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-09-08 18:31 ` Jason Gunthorpe
[not found] ` <20160908183122.GC21614-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-08 18:54 ` Hal Rosenstock
[not found] ` <fdbfdc86-80d2-bb12-e69a-d4b7976bfba6-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-09-08 19:38 ` Jason Gunthorpe
[not found] ` <20160908193815.GA2424-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-08 19:47 ` Steve Wise
2016-09-09 4:28 ` Doug Ledford
[not found] ` <7df61de8-0999-1ba6-7381-be9753157650-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-13 17:16 ` Hefty, Sean
2016-09-11 12:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907040925.GA27361@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=Devesh.sharma-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org \
--cc=Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=christoph-zt5rKe7wo/JBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
--cc=vlad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).