From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH] IB/mlx5: Fix decision to avoid using MAD_IFC command in ISSI > 0 mode Date: Tue, 13 Sep 2016 08:52:23 +0300 Message-ID: <20160913055223.GM8812@leon.nu> References: <1473232990-22766-1-git-send-email-dchang@suse.com> <20160908140752.GN18398@leon.nu> <20160909025527.GC3042@linux-kyyb.suse> <20160910074719.GG6415@leon.nu> <20160911071542.GH6415@leon.nu> <20160913014023.GI3042@linux-kyyb.suse> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="j3zO+32zXj6UcJCE" Return-path: Content-Disposition: inline In-Reply-To: <20160913014023.GI3042-5oAczMR2RyTI588T0lkTTQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Chang Cc: Doug Ledford , Matan Barak , Majd Dibbiny , Eli Cohen , Or Gerlitz , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org --j3zO+32zXj6UcJCE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 13, 2016 at 09:40:23AM +0800, David Chang wrote: > On Sun, Sep 11, 2016 at 10:15:42AM +0300, Leon Romanovsky wrote: > > On Sat, Sep 10, 2016 at 10:47:19AM +0300, Leon Romanovsky wrote: > > Hi David, > > > > Please find this UNTESTED patch. We will do formal testing during the > > coming work week and will properly submit it for inclusion for 4.8. > > From 9147fabc9b189e09a982de8ac30f01f04468f6ce Mon Sep 17 00:00:00 2001 > > From: Noa Osherovich > > Date: Sun, 11 Sep 2016 10:00:27 +0300 > > Subject: [PATCH rdma-rc] IB/mlx5: Enable MAD_IFC commands for IB ports only > > > > MAD_IFC command is supported only for physical function (PF) drivers > > and only when physical port is IB. > > > > The lack of check if port is IB caused to following trace to appear. > > > > [ 8.456327] mlx5_core 0000:03:00.0: firmware version: 12.12.780 > > ... > > [ 10.417421] mlx5_ib: Mellanox Connect-IB Infiniband driver v2.2-1 (Feb 2014) > > [ 10.419282] ------------[ cut here ]------------ > > [ 10.419291] WARNING: CPU: 2 PID: 2517 at ../drivers/infiniband/core/cache.c:702 ib_cache_gid_set_default_gid+0x2f8/0x340 [ib_core]() > > [ 10.419386] CPU: 2 PID: 2517 Comm: modprobe Tainted: G X 4.4.19-1-default #1 > > [ 10.419387] Hardware name: Dell Inc. PowerEdge R730xd/072T6D, BIOS2.1.7 06/16/2016 > > [ 10.419389] 0000000000000000 ffffffff8130d740 0000000000000000 ffffffffa04e0300 > > [ 10.419395] ffffffff8107c121 > > [ 10.419400] ffff88017bfe0000 ffff88003712b9e0 ffff88045ad905c0 > > [ 10.419401] 0000000000000001 fffffffffffffffc ffffffffa04d8a58 0000000000000000 > > [ 10.419406] Call Trace: > > [ 10.419415] [] dump_trace+0x59/0x310 > > [ 10.419419] [] show_stack_log_lvl+0xea/0x170 > > [ 10.419421] [] show_stack+0x21/0x40 > > [ 10.419426] [] dump_stack+0x5c/0x7c > > [ 10.419431] [] warn_slowpath_common+0x81/0xb0 > > [ 10.419436] [] ib_cache_gid_set_default_gid+0x2f8/0x340 [ib_core] > > [ 10.419449] [] add_netdev_ips+0x9d/0xa0 [ib_core] > > [ 10.419456] [] enum_all_gids_of_dev_cb+0x7b/0xb0 [ib_core] > > [ 10.419461] [] ib_enum_roce_netdev+0xdd/0x100 [ib_core] > > [ 10.419466] [] roce_rescan_device+0x1d/0x20 [ib_core] > > [ 10.419470] [] ib_cache_setup_one+0x23b/0x3d0 [ib_core] > > [ 10.419475] [] ib_register_device+0x2bb/0x4f0 [ib_core] > > [ 10.419483] [] mlx5_ib_add+0xaaf/0x12e0 [mlx5_ib] > > [ 10.419492] [] mlx5_add_device+0x41/0xa0 [mlx5_core] > > [ 10.419498] [] mlx5_register_interface+0x65/0xa0 [mlx5_core] > > [ 10.419502] [] mlx5_ib_init+0x30/0x42 [mlx5_ib] > > [ 10.419506] [] do_one_initcall+0xc8/0x1f0 > > [ 10.419510] [] do_init_module+0x5a/0x1d7 > > [ 10.419514] [] load_module+0x1366/0x1c50 > > [ 10.419518] [] SYSC_finit_module+0x70/0xa0 > > [ 10.419523] [] entry_SYSCALL_64_fastpath+0x12/0x6d > > [ 10.420681] DWARF2 unwinder stuck at entry_SYSCALL_64_fastpath+0x12/0x6d > > [ 10.420682] Leftover inexact backtrace: > > [ 10.420684] ---[ end trace fc8ccb16c9d8e28a ]--- > > > > Reported-by: David Chang > > Signed-off-by: Noa Osherovich > > Signed-off-by: Leon Romanovsky > > --- > > drivers/infiniband/hw/mlx5/main.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c > > index 8150ea3..0480b64 100644 > > --- a/drivers/infiniband/hw/mlx5/main.c > > +++ b/drivers/infiniband/hw/mlx5/main.c > > @@ -288,7 +288,9 @@ __be16 mlx5_get_roce_udp_sport(struct mlx5_ib_dev *dev, u8 port_num, > > > > static int mlx5_use_mad_ifc(struct mlx5_ib_dev *dev) > > { > > - return !MLX5_CAP_GEN(dev->mdev, ib_virt); > > + if (MLX5_CAP_GEN(dev->mdev, port_type) == MLX5_CAP_PORT_TYPE_IB) > > + return !MLX5_CAP_GEN(dev->mdev, ib_virt); > > + return 0; > > } > > > > enum { > > -- > > 2.7.4 > > We tested this patch with both fw:12.12.780 and fw:12.16.1020. > > We could ping each other and could check RoCE v1 and v2 using ib_send_bw > as per https://community.mellanox.com/docs/DOC-2415 on both of these > firmwares. > > Reported-and-tested-by: Sujith Pandel hi David, Thank you for the update. The good thing that this patch was sent yesterday to ML for inclusion in 4.8 [1], and the bad thing that patchworks didn't catch my attempt to add this tag to the patch. I assume that it didn't recognize it. Thanks [1] https://patchwork.kernel.org/patch/9326963/ > > Thanks, > David Chang > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --j3zO+32zXj6UcJCE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX15QXAAoJEORje4g2clinjDAQAJFD1hQOUJYSQC9PE7XG/iEE mWLyG1kDy/16Q85oxN+RTrr3T6F6HLa5LrYIS4L+LgJu2yUVp9lzmUEGUs4d2YfQ 2ka6L791z07O2BfGqYGBC64u/hOhujQL6aipg0UFJoUPPSnl/dp+yX7Fj6DhxRxW lucSOEC/1BfLG5mgOXC15DiNBYnuSMAY5lmeoicK1/3tXGuMAsOzdDfCnz26GLTr HAuWj8UHJRr+Rm82Jx1jLseHfm6L7t0FIX4Em4GA+T4h3kEWoGqnlQKAjQM0BwYF yM/+FLg1MkgC+V7O3LrQgPio2tFqQs8lhn379kyB1VxWED0IMJXs56uz9JZUmIs1 Ix1DAhtbBYo36be9fhgVnQyz1tzSFXBE2ZrFwxjfpiAN358g97FE6RYhmBtLJP+4 VMttaPO+flcjzPq/6vp4bdGEdgxzHzJ3mKTUBTgJN63XSyMSH4mSLYlwCFSvBFc+ n0wRjiu9F6eqm3sM6iUXQCB13ZvUXTQcxvIpKEhVtnb73420Rufw+PHrlYBx4MD/ UzUxLnaOTE033wMiQaKUUmjmJuokzQwgobnM6zO0YZpoxrJX6Qj6iRFktypvLQk3 ZAJe596EsCQERqVzUkNHmzObfCRmg6UKongLBgOz/4llWujtIP5ggmt6Ux+UKUvp oVt4d5VaNUr7OmbO9U2I =97My -----END PGP SIGNATURE----- --j3zO+32zXj6UcJCE-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html