From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 02/28] Include pthreads in the provider libraries Date: Wed, 14 Sep 2016 10:01:50 -0600 Message-ID: <20160914160150.GA16014@obsidianresearch.com> References: <1473109698-31408-1-git-send-email-jgunthorpe@obsidianresearch.com> <1473109698-31408-3-git-send-email-jgunthorpe@obsidianresearch.com> <2961f191-3020-ed18-0200-ce569c19326b@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2961f191-3020-ed18-0200-ce569c19326b-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yishai Hadas Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Devesh Sharma , Hal Rosenstock , Mike Marciniszyn , Moni Shoua , Sean Hefty , Steve Wise , Tatyana Nikolova , Vladimir Sokolovsky , Yishai Hadas List-Id: linux-rdma@vger.kernel.org On Wed, Sep 14, 2016 at 06:15:45PM +0300, Yishai Hadas wrote: > On 9/6/2016 12:07 AM, Jason Gunthorpe wrote: > >It is a mistake to not explicitly link to the libraries required. > >Not linking causes the symbols to drop the symbol version which could > >cause runtime problems down the road if pthreads ever goes through > >another symbol version change. > > Where in this patch the provider links explicitly with pthreads as you > pointed that should be done ? can see only a check that pthread exists and > has the pthread_mutex_init symbol. AC_CHECK_LIB adds the library to the link line as well. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html