From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
"yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 11/16] Remove the auto* based build systems
Date: Wed, 21 Sep 2016 09:44:21 -0600 [thread overview]
Message-ID: <20160921154421.GA1510@obsidianresearch.com> (raw)
In-Reply-To: <6e3d2ab0-7c86-fe1c-affd-b7fb9ba59c20-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Wed, Sep 21, 2016 at 04:53:23PM +0300, Yishai Hadas wrote:
> On 9/21/2016 1:10 AM, Jason Gunthorpe wrote:
> >The unified cmake version provides the same functionality now.
>
> Can you explain how cmake preservers some compilation options which were
> enabled per vendor ? for example with previous build system someone could
> run configure of libmlx5 with --with-mlx5_debug, how can it be done now ?
On option is to do the usual 'CPPFLAGS="-DMLX5_DEBUG" cmake ..'
However we may as well document these options and provide a command
line switch as follows:
>From f964f6be593b7ef362af3168bd3c6bc8640b976d Mon Sep 17 00:00:00 2001
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Date: Wed, 21 Sep 2016 09:42:16 -0600
Subject: [PATCH] mlx5: Add cmake options to replace --with-mlx5_debug/mw_debug
Simply enable -D flags when building.
Use as:
$ cmake -DMLX5_DEBUG=TRUE -DMLX5_MW_DEBUG=TRUE
Reported-by: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
providers/mlx5/CMakeLists.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/providers/mlx5/CMakeLists.txt b/providers/mlx5/CMakeLists.txt
index a34a8063eeb2..44df83b47d96 100644
--- a/providers/mlx5/CMakeLists.txt
+++ b/providers/mlx5/CMakeLists.txt
@@ -1,3 +1,15 @@
+set(MLX5_DEBUG "FALSE" CACHE BOOL
+ "Enable expensive runtime logging options for the mlx5 verbs provider")
+if (MLX5_DEBUG)
+ add_definitions("-DMLX5_DEBUG")
+endif()
+
+set(MLX5_MW_DEBUG "FALSE" CACHE BOOL
+ "Enable extra validation of memory windows for the mlx5 verbs provider")
+if (MLX5_MW_DEBUG)
+ add_definitions("-DMW_DEBUG")
+endif()
+
rdma_provider(mlx5
buf.c
cq.c
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-21 15:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 22:10 [PATCH 00/16] Consolidated RDMA userspace: rdma-core Jason Gunthorpe
[not found] ` <1474409425-15769-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-20 22:10 ` [PATCH 01/16] Fix bogus executable file permissions Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 02/16] Include pthreads in the provider libraries Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 03/16] Be explicit about _GNU_SOURCE Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 04/16] hfi/ipath: Use the name of the provider for the .driver file Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 05/16] ibcm: Actually use the version script when linking Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 06/16] iwpm: Update autotools enough to build Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 07/16] rdmacm: Control symbol export from librspreload Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 08/16] Unified CMake build system Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 09/16] Support obsolete cmake from 2013 Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 10/16] Add a MAINTAINERS file Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 11/16] Remove the auto* based build systems Jason Gunthorpe
[not found] ` <1474409425-15769-12-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-21 13:53 ` Yishai Hadas
[not found] ` <6e3d2ab0-7c86-fe1c-affd-b7fb9ba59c20-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-09-21 15:44 ` Jason Gunthorpe [this message]
2016-09-20 22:10 ` [PATCH 12/16] Remove the ChangeLog files Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 13/16] Remove Debian and RPM packaging files Jason Gunthorpe
[not found] ` <1474409425-15769-14-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-21 14:00 ` Yishai Hadas
[not found] ` <2447bfda-5a48-18db-94b3-d031d5913a8e-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-09-21 15:52 ` Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 14/16] ibacm: Remove windows support files Jason Gunthorpe
[not found] ` <1474409425-15769-15-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-21 20:17 ` Hefty, Sean
2016-09-20 22:10 ` [PATCH 15/16] Remove README files in the provider directories Jason Gunthorpe
2016-09-20 22:10 ` [PATCH 16/16] Remove iwpmd/README Jason Gunthorpe
2016-09-21 22:01 ` [PATCH 00/16] Consolidated RDMA userspace: rdma-core Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921154421.GA1510@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=alaa-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox