Re: [PATCH 11/13] srp_daemon: Add the debian initscripts as an option

Jason Gunthorpe
2016-09-28T18:47:08Z

On Wed, Sep 28, 2016 at 02:27:01PM -0400, Doug Ledford wrote:
> On 9/23/16 3:17 PM, Jason Gunthorpe wrote:
> > Necessary to reproduce the Debian packaging.
> >
> > Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> > CMakeLists.txt | 3 ++
> > srp_daemon/srp_daemon/CMakeLists.txt | 29 ++++++++----
> > srp_daemon/srptools.default | 14 ++++++
> > srp_daemon/srptools.init | 89 ++++++++++++++++++++++++++++++++++++
>
> Would it be best to have directories for related install files for a
> specific OS? For instance, srp_daemon/debian/ and srp_daemon/redhat/?
> It's not that I expect to put a redhat init script for srpd in place,
> but the script for debian is likely to not work properly on redhat, so
> having it in an OS directory would at least make that clear.

To be clear, there is already an initscript that (perhaps?) is for
RedHat - but it isn't even close to the Debian version. So this patch
introduces two scripts for srp_dameon, which I hated doing..

I'll drop this patch from the series and we can go ahead with the
other patches in the series.

For now I'll put the initscript in the Debian packaging patch and we
can think about what to do later. I think it can be moved to the
debian/ directory as well.

Going forward I think we need to make some decisions..

1) Do we want to do something with the initscripts so distros can use
them? Is that even possible? I think Debian uses the bundled
acm initscript, didn't look at suse.

Is Debian the only major distro that still ships init scripts?
Does FC/RH exclusively ship systemd unit files now?

Maybe we should delete the initscripts entirely.

2) I'd like to support cross-distro systemd unit files upstream.
Is that feasible? We are short unit files, could you
contribute yours?

Jason