Re: [PATCH 11/13] srp_daemon: Add the debian initscripts as an option

Doug Ledford
2016-09-28T18:55:11Z

[-- Attachment #1.1: Type: text/plain, Size: 3331 bytes --]

On 9/28/16 2:47 PM, Jason Gunthorpe wrote:
> On Wed, Sep 28, 2016 at 02:27:01PM -0400, Doug Ledford wrote:
>> On 9/23/16 3:17 PM, Jason Gunthorpe wrote:
>>> Necessary to reproduce the Debian packaging.
>>>
>>> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
>>> CMakeLists.txt | 3 ++
>>> srp_daemon/srp_daemon/CMakeLists.txt | 29 ++++++++----
>>> srp_daemon/srptools.default | 14 ++++++
>>> srp_daemon/srptools.init | 89 ++++++++++++++++++++++++++++++++++++
>>
>> Would it be best to have directories for related install files for a
>> specific OS? For instance, srp_daemon/debian/ and srp_daemon/redhat/?
>> It's not that I expect to put a redhat init script for srpd in place,
>> but the script for debian is likely to not work properly on redhat, so
>> having it in an OS directory would at least make that clear.
>
> To be clear, there is already an initscript that (perhaps?) is for
> RedHat - but it isn't even close to the Debian version. So this patch
> introduces two scripts for srp_dameon, which I hated doing..
>
> I'll drop this patch from the series and we can go ahead with the
> other patches in the series.
>
> For now I'll put the initscript in the Debian packaging patch and we
> can think about what to do later. I think it can be moved to the
> debian/ directory as well.
>
> Going forward I think we need to make some decisions..
>
> 1) Do we want to do something with the initscripts so distros can use
> them? Is that even possible? I think Debian uses the bundled
> acm initscript, didn't look at suse.

I'm in favor of providing a good, reliable, correct set of startup files
for each of the major distro flavors. One of my main reasons for that
is it makes it possible for us to try and provide some level of startup
script parity and commonality between the distros. And allows us to fix
bugs across all the distros as once even if we didn't necessarily hit
the bug on each distro. Of course, the distros may ignore our scripts,
but we can try.

>
> Is Debian the only major distro that still ships init scripts?
> Does FC/RH exclusively ship systemd unit files now?

We're almost entirely systemd now. We only have EL 6 that still uses
init scripts, and I doubt we will ever put this package into EL 6. So,
we might as well be all systemd as far as this repo is concerned.

> Maybe we should delete the initscripts entirely.

Not if Debian still uses it. And I'm not opposed to providing a Red Hat
init script in case someone wants to put this package on EL 6 themselves.

> 2) I'd like to support cross-distro systemd unit files upstream.
> Is that feasible?

Maybe....I'm not entirely sure about that.

> We are short unit files, could you
> contribute yours?

Absolutely. I'd like to basically import the entire redhat rdma package
into this, but it will take a little sorting things out to get all of
the files and such in the right place. And that's a precursor to our
srpd unit file as it lists a specific dependency on the rdma unit file.

--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG Key ID: 0E572FDD
Red Hat, Inc.
100 E. Davie St
Raleigh, NC 27601 USA

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 907 bytes --]