Re: [PATCH 11/13] srp_daemon: Add the debian initscripts as an option

Doug Ledford
2016-09-28T21:11:24Z

[-- Attachment #1.1: Type: text/plain, Size: 1459 bytes --]

On 9/28/16 5:01 PM, Jason Gunthorpe wrote:
> On Wed, Sep 28, 2016 at 01:18:51PM -0700, Bart Van Assche wrote:
>> On 09/28/2016 11:47 AM, Jason Gunthorpe wrote:
>>> To be clear, there is already an initscript that (perhaps?) is for
>>> RedHat - but it isn't even close to the Debian version. So this patch
>>> introduces two scripts for srp_dameon, which I hated doing..
>>
>> The existing init script works reliably on multiple versions of RHEL, SLES,
>> Fedora and openSuSE. It is not specific to Red Hat distro's. So I'm
>> surprised that a separate initscript is needed for Debian?
>
> I suspect not being distro specific is the entire problem,

Indeed...

> eg the
> Debian initscript is using /etc/default/srptools to configure
> how the daemon is launched and it uses the start-stop-daemon tool.
>
> A good initscript should consistently follow the distro policies for
> initscripts..

Exactly why we often don't use the ones in the upstream package. Try to
be generically good, and you will be universally, generically bad for
any specific distro. If you want to provide one as an example, that's
fine. If you want to provide one that's actually used, then you need
one per distro (or a means of generating a distro specific one from a
template or some such).

--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG Key ID: 0E572FDD
Red Hat, Inc.
100 E. Davie St
Raleigh, NC 27601 USA

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 907 bytes --]