From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 2/9] Remove HAVE_VALGRIND_MEMCHECK_H/INCLUDE_VALGRIND Date: Thu, 29 Sep 2016 16:34:15 -0600 Message-ID: <20160929223415.GD27229@obsidianresearch.com> References: <1475182076-5411-1-git-send-email-jgunthorpe@obsidianresearch.com> <1475182076-5411-3-git-send-email-jgunthorpe@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sean Hefty , Hal Rosenstock , Doug Ledford , Yishai Hadas , Vladimir Sokolovsky List-Id: linux-rdma@vger.kernel.org On Thu, Sep 29, 2016 at 02:01:26PM -0700, Bart Van Assche wrote: > Independent of this patch: Valgrind has a stable ABI so I propose to add a > copy of the memcheck.h header file to the rdma-core source tree. Many other > open source projects already do this. Interesting idea, what do you see as the benefit? FWIW, I haven't had any problems getting the valgrind headers on any supported distro. I think I'd rather make the absence of valgrind a hard error (right now cmake makes a warning in the summary) than worry about another copied header... Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html