From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Henry Orosco <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] i40iw: Add Quality of Service support
Date: Sat, 8 Oct 2016 18:41:39 +0300 [thread overview]
Message-ID: <20161008154139.GZ9282@leon.nu> (raw)
In-Reply-To: <20161006212659.GB6664-ZmvEvTIhtuUfyugFOqMDN/ooFf0ArEBIu+b9c/7xato@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2323 bytes --]
On Thu, Oct 06, 2016 at 04:26:59PM -0500, Henry Orosco wrote:
> On Thu, Oct 06, 2016 at 07:00:16PM +0300, Leon Romanovsky wrote:
> > On Thu, Oct 06, 2016 at 10:21:28AM -0500, Henry Orosco wrote:
> > > Add support for QoS on QPs. Upon device initialization,
> > > a map is created from user priority to queue set
> > > handles. On QP creation, use ToS to look up the queue
> > > set handle for use with the QP.
> > >
> > > Signed-off-by: Faisal Latif <faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Henry Orosco <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > ---
> > > drivers/infiniband/hw/i40iw/i40iw.h | 9 ++
> > > drivers/infiniband/hw/i40iw/i40iw_cm.c | 30 +++++-
> > > drivers/infiniband/hw/i40iw/i40iw_cm.h | 2 +-
> > > drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 151 +++++++++++++++++++++++++++++-
> > > drivers/infiniband/hw/i40iw/i40iw_d.h | 2 +
> > > drivers/infiniband/hw/i40iw/i40iw_hw.c | 25 ++---
> > > drivers/infiniband/hw/i40iw/i40iw_main.c | 64 +++++++++++--
> > > drivers/infiniband/hw/i40iw/i40iw_osdep.h | 2 +
> > > drivers/infiniband/hw/i40iw/i40iw_p.h | 2 +
> > > drivers/infiniband/hw/i40iw/i40iw_puda.c | 3 +-
> > > drivers/infiniband/hw/i40iw/i40iw_type.h | 18 +++-
> > > drivers/infiniband/hw/i40iw/i40iw_utils.c | 45 +++++++++
> > > drivers/infiniband/hw/i40iw/i40iw_verbs.c | 6 +-
> > > 13 files changed, 323 insertions(+), 36 deletions(-)
> >
> > I believe that it can be split to series.
>
> As all this code is a logical unit for QoS support, we thought
> it best to submit as a single patch.
Large logical unit --> patchset
~400 lines of code --> large unit
>
> Doug, what is your preference?
> >
> > > mode change 100644 => 100755 drivers/infiniband/hw/i40iw/i40iw_cm.c
> > > mode change 100644 => 100755 drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> >
> > Why did you change file's mode from 644 to 755?
>
> Nice catch! Will send out another version with this fixed.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-10-08 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 15:21 [PATCH] i40iw: Add Quality of Service support Henry Orosco
[not found] ` <20161006152128.14940-1-henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-06 16:00 ` Leon Romanovsky
[not found] ` <20161006160016.GQ9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-06 21:26 ` Henry Orosco
[not found] ` <20161006212659.GB6664-ZmvEvTIhtuUfyugFOqMDN/ooFf0ArEBIu+b9c/7xato@public.gmane.org>
2016-10-08 15:41 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161008154139.GZ9282@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).