From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 12/32] iwpmd: fix the prototype for the pthread_create start functions Date: Thu, 13 Oct 2016 13:44:16 -0600 Message-ID: <20161013194416.GA7654@obsidianresearch.com> References: <1476381095-20041-1-git-send-email-hch@lst.de> <1476381095-20041-13-git-send-email-hch@lst.de> <021b01d22585$5b60bbf0$122233d0$@opengridcomputing.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <021b01d22585$5b60bbf0$122233d0$@opengridcomputing.com> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steve Wise Cc: 'Christoph Hellwig' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, Oct 13, 2016 at 02:09:44PM -0500, Steve Wise wrote: > > @@ -1438,11 +1438,11 @@ int main(int argc, char *argv[]) > > pthread_cond_init(&cond_req_complete, NULL); > > pthread_cond_init(&cond_pending_msg, NULL); > > > > - ret = pthread_create(&map_req_thread, NULL, > > &iwpm_mapping_reqs_handler, NULL); > > + ret = pthread_create(&map_req_thread, NULL, > > iwpm_mapping_reqs_handler, NULL); > > if (ret) > > goto error_exit; > > > > - ret = pthread_create(&pending_msg_thread, NULL, > > &iwpm_pending_msgs_handler, NULL); > > + ret = pthread_create(&pending_msg_thread, NULL, > > iwpm_pending_msgs_handler, NULL); > > if (ret) > > goto error_exit; > > How did this work before? gcc will not warn if an old-style prototype eg () is passed in to a typed function pointer. An earlier patch in the series changed it to (void) which broke the compile.. I reorderd things to avoid this in the PR. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html