From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 6/8] IB/hns: Replace counting semaphore event_sem with wait condition Date: Mon, 17 Oct 2016 09:39:28 -0700 Message-ID: <20161017163927.GA7207@infradead.org> References: <1476721862-7070-1-git-send-email-binoy.jayan@linaro.org> <1476721862-7070-7-git-send-email-binoy.jayan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1476721862-7070-7-git-send-email-binoy.jayan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Binoy Jayan Cc: Doug Ledford , Sean Hefty , Hal Rosenstock , Arnd Bergmann , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Mon, Oct 17, 2016 at 10:01:00PM +0530, Binoy Jayan wrote: > Counting semaphores are going away in the future, so replace the semaphore > hns_roce_cmdq::event_sem with an open-coded implementation. Sorry, but no. Using a proper semaphore abstraction is always better than open coding it. While most semaphore users should move to better primitives, those that actually are counting semaphore should stick to the existing primitive. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html