Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: "ira. weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH TRIVIAL infiniband-diags] ibaddr.c: Fix LID printfs to be unsigned rather than signed
Date: Tue, 18 Oct 2016 12:27:08 -0400	[thread overview]
Message-ID: <20161018162707.GB16254@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <b0f11628-e2ef-15d9-5a9e-68edbc81ca77-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>

On Mon, Sep 26, 2016 at 07:38:46AM -0400, Hal Rosenstock wrote:
> 
> %u is what's used in other places for unicast LIDs
> 
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks applied,
Ira

> ---
> diff --git a/src/ibaddr.c b/src/ibaddr.c
> index 5845b4e..1a721d0 100644
> --- a/src/ibaddr.c
> +++ b/src/ibaddr.c
> @@ -83,7 +83,7 @@ static int ib_resolve_addr(ib_portid_t * portid, int portnum, int show_lid,
>  		printf("LID start 0x%x end 0x%x", portid->lid,
>  		       portid->lid + (1 << lmc) - 1);
>  	else if (show_lid < 0)
> -		printf("LID start %d end %d", portid->lid,
> +		printf("LID start %u end %u", portid->lid,
>  		       portid->lid + (1 << lmc) - 1);
>  	printf("\n");
>  	return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2016-10-18 16:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 11:38 [PATCH TRIVIAL infiniband-diags] ibaddr.c: Fix LID printfs to be unsigned rather than signed Hal Rosenstock
     [not found] ` <b0f11628-e2ef-15d9-5a9e-68edbc81ca77-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-10-18 16:27   ` ira. weiny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018162707.GB16254@phlsvsds.ph.intel.com \
    --to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox