Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Amrani, Ram]

Hi Jason,
Yesterday the qedr (Qlogic Everest Driver for RDMA) patch was sent.
Even before it being accepted I would like to start working on preparing and adding our user space library for qedr (libqedr) to the consolidated userspace RDMA library repo.
I see that a lot of work is being done by you and so I want to understand how to prepare the code, what is the process and when is a good time to join.

Thanks,
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Jason Gunthorpe]

On Thu, Oct 06, 2016 at 08:08:29AM +0000, Amrani, Ram wrote:
> Hi Jason,
> Yesterday the qedr (Qlogic Everest Driver for RDMA) patch was sent.

> Even before it being accepted I would like to start working on
> preparing and adding our user space library for qedr (libqedr) to
> the consolidated userspace RDMA library repo.  I see that a lot of
> work is being done by you and so I want to understand how to prepare
> the code, what is the process and when is a good time to join.

Hi Ram,

If you prepare a branch of rdma-core on github I can give it a quick
look over.

The technical steps are fairly simple, create a
provider/qedr directory, add your source code, copy the CMakeLists.txt
style from another provider, add a line to the sorted list in the top
level CMakeLists.txt, update README.md, COPYING.md and MAINTAINERS

You will want to look at the various patches I've prepared and ensure
you cover off the basic cleanups that have already been done, and that
your code compiles warning-free on FC24.

Once you feel everything is ready then post it to the mailing list and
send a pull request. For the mailing list you can just split the
patches by file..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Amrani, Ram]

>If you prepare a branch of rdma-core on github I can give it a quick
>look over.
>
>The technical steps are fairly simple, create a
>provider/qedr directory, add your source code, copy the CMakeLists.txt
>style from another provider, add a line to the sorted list in the top
>level CMakeLists.txt, update README.md, COPYING.md and MAINTAINERS
>
>You will want to look at the various patches I've prepared and ensure
>you cover off the basic cleanups that have already been done, and that
>your code compiles warning-free on FC24.
>
>Once you feel everything is ready then post it to the mailing list and
>send a pull request. For the mailing list you can just split the
>patches by file..
>
>Jason

Thanks, we'll start on it.


    --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Amrani, Ram]

> >You will want to look at the various patches I've prepared and ensure
> >you cover off the basic cleanups that have already been done, and that
> >your code compiles warning-free on FC24.

By cleanups, do you mean to make sure the code compiles warning-free under 
the various flags mentioned throughout the git log (-Wempty-body and etc.),
or are there other kinds of cleanups that I'm missing?

> >Once you feel everything is ready then post it to the mailing list and
> >send a pull request. For the mailing list you can just split the
> >patches by file..

As we don't have a publically accessed server I cannot do this at the moment (I'm checking how we can set one up).
Is it OK if I send you the update as a series of patches?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Jason Gunthorpe]

On Thu, Oct 13, 2016 at 02:37:24PM +0000, Amrani, Ram wrote:
> > >You will want to look at the various patches I've prepared and ensure
> > >you cover off the basic cleanups that have already been done, and that
> > >your code compiles warning-free on FC24.
> 
> By cleanups, do you mean to make sure the code compiles warning-free under 
> the various flags mentioned throughout the git log (-Wempty-body and etc.),

Yes, Travis will enforce this.

> or are there other kinds of cleanups that I'm missing?

Yes, many of the drivers copied the same stuff that is now gone. Here
is a sampling

https://github.com/linux-rdma/rdma-core/commit/1df0888f6a736e1612ce8b054d6c17651ebd003f
https://github.com/linux-rdma/rdma-core/commit/6771a2051ea5efd30e142866f722d2dae6f565a7
https://github.com/linux-rdma/rdma-core/commit/f29b3285f82815da3abdfea5be5c4f2d1ca92743
https://github.com/linux-rdma/rdma-core/commit/9358a8a5484d1caa0c7ad1826e07d2105f58cc4e
https://github.com/linux-rdma/rdma-core/commit/c5c7e32796b19c3707620a3d2f6b32d00d2fbc3c

> > >Once you feel everything is ready then post it to the mailing list and
> > >send a pull request. For the mailing list you can just split the
> > >patches by file..
> 
> As we don't have a publically accessed server I cannot do this at
> the moment (I'm checking how we can set one up).  Is it OK if I send
> you the update as a series of patches?

You don't need a server, just a personal github account.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Amrani, Ram]

>Yes, many of the drivers copied the same stuff that is now gone. Here



>is a sampling
>
>https://github.com/linux-rdma/rdma-core/commit/1df0888f6a736e1612ce8b054d6c17651ebd003f
>https://github.com/linux-rdma/rdma-core/commit/6771a2051ea5efd30e142866f722d2dae6f565a7
>https://github.com/linux-rdma/rdma-core/commit/f29b3285f82815da3abdfea5be5c4f2d1ca92743
>https://github.com/linux-rdma/rdma-core/commit/9358a8a5484d1caa0c7ad1826e07d2105f58cc4e
>https://github.com/linux-rdma/rdma-core/commit/c5c7e32796b19c3707620a3d2f6b32d00d2fbc3c

OK, this is more clear to me now. I'll look up the git log to see if there are other relevant cleanups.

>You don't need a server, just a personal github account.
Oh, that sounds much simpler. I'll give it a try.
If I follow correctly, I create a github account, clone rdma-plumbing, add our code onto that
and send you a pull request.


Thanks,
Ram



    --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Jason Gunthorpe]

On Fri, Oct 14, 2016 at 12:53:34PM +0000, Amrani, Ram wrote:

> If I follow correctly, I create a github account, clone
> rdma-plumbing,?add our code onto that and send you a pull request.

Yes.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Amrani, Ram]

Hi Jason,
I've created a user account on github, forked rdma_plumbing and added libqedr in multiple patches,
after I've verified that it builds warning free and in-line with previous cleanups.
I've sent a pull request to linux-rdma rather than rdma-plumbing. Is that OK?

Thanks,
Ram

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

On Wed, Oct 19, 2016 at 04:08:12PM +0000, Amrani, Ram wrote:
> Hi Jason,
> I've created a user account on github, forked rdma_plumbing and added libqedr in multiple patches,
> after I've verified that it builds warning free and in-line with previous cleanups.
> I've sent a pull request to linux-rdma rather than rdma-plumbing. Is that OK?

Please post them to the ML for review.
Thanks

>
> Thanks,
> Ram
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Jason Gunthorpe]

On Wed, Oct 19, 2016 at 04:08:12PM +0000, Amrani, Ram wrote:
> Hi Jason,
> I've created a user account on github, forked rdma_plumbing and added libqedr in multiple patches,
> after I've verified that it builds warning free and in-line with previous cleanups.
> I've sent a pull request to linux-rdma rather than rdma-plumbing. Is that OK?

So far so good.

As Leon said, post your patches to the mailing list.

You also need to make sure it builds, Travis says the 32 bit builds
are no good (look at the pull request and click on the red X)

The github process from here is to make changes and then update your
branch on your github, that will reflect in the pull request. Eg you
can immediately fix the 32 bit issues and see that travis goes green.

I left some minor notes for you on github, the build system stuff
looks fine to me, and I didn't notice anything too unusual in a casual
browse. Didn't check if the code was any good..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Amrani, Ram]

> You also need to make sure it builds, Travis says the 32 bit builds are no good
> (look at the pull request and click on the red X)

That's true, I haven't checked those. I will.

> The github process from here is to make changes and then update your branch
> on your github, that will reflect in the pull request. Eg you can immediately fix
> the 32 bit issues and see that travis goes green.

OK

> I left some minor notes for you on github, the build system stuff looks fine to
> me, and I didn't notice anything too unusual in a casual browse. Didn't check if
> the code was any good..

OK

Thanks,
Ram

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 1162 bytes --]

On 10/20/2016 2:16 AM, Amrani, Ram wrote:
>> You also need to make sure it builds, Travis says the 32 bit builds are no good
>> (look at the pull request and click on the red X)
> 
> That's true, I haven't checked those. I will.
> 
>> The github process from here is to make changes and then update your branch
>> on your github, that will reflect in the pull request. Eg you can immediately fix
>> the 32 bit issues and see that travis goes green.
> 
> OK
> 
>> I left some minor notes for you on github, the build system stuff looks fine to
>> me, and I didn't notice anything too unusual in a casual browse. Didn't check if
>> the code was any good..
> 
> OK

I saw you fixed up the things Jason had referred to.  I merged your
request, but there is still an outstanding build issue (I couldn't get
to the travis logs to see it at the time, but Jason let me know it was a
real issue, not an issue with Travis CI).  Please get that fixed up as
soon as possible.  As soon as the build fix is available we need to get
it merged in too.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 1501 bytes --]

On 10/21/2016 4:10 PM, Doug Ledford wrote:
> On 10/20/2016 2:16 AM, Amrani, Ram wrote:
>>> You also need to make sure it builds, Travis says the 32 bit builds are no good
>>> (look at the pull request and click on the red X)
>>
>> That's true, I haven't checked those. I will.
>>
>>> The github process from here is to make changes and then update your branch
>>> on your github, that will reflect in the pull request. Eg you can immediately fix
>>> the 32 bit issues and see that travis goes green.
>>
>> OK
>>
>>> I left some minor notes for you on github, the build system stuff looks fine to
>>> me, and I didn't notice anything too unusual in a casual browse. Didn't check if
>>> the code was any good..
>>
>> OK
> 
> I saw you fixed up the things Jason had referred to.  I merged your
> request, but there is still an outstanding build issue (I couldn't get
> to the travis logs to see it at the time, but Jason let me know it was a
> real issue, not an issue with Travis CI).  Please get that fixed up as
> soon as possible.  As soon as the build fix is available we need to get
> it merged in too.
> 
> 

And for those that don't know, the Internet is down for many of us today
:-/.  A DDoS has been undergoing against Level3 Network's distributed
DNS system, taking out many services, including github.com.

http://thehackernews.com/2016/10/dyn-dns-ddos.html

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Amrani, Ram]

>I saw you fixed up the things Jason had referred to.  I merged your
>request, but there is still an outstanding build issue (I couldn't get
>to the travis logs to see it at the time, but Jason let me know it was a
>real issue, not an issue with Travis CI).  Please get that fixed up as
>soon as possible.  As soon as the build fix is available we need to get
>it merged in too.

The only outstanding "real" issue I'm aware of is compilation in 32-bit
as reported by Travis CI. I have a patch ready for it but I cannot send it 
right now (it's Holiday and I'm away). I guess I will be able to pull it off
tonight (in 12 hours) or tomorrow morning.

Do let me know if there's anything else ("but Jason let me know it was a
real issue, not an issue with Travis CI").

Thanks,
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Amrani, Ram]

>The only outstanding "real" issue I'm aware of is compilation in 32-bit
>as reported by Travis CI. I have a patch ready for it but I cannot send it 
>right now (it's Holiday and I'm away). I guess I will be able to pull it off
>tonight (in 12 hours) or tomorrow morning.

I just created a pull request, earlier than I expected.
The commit was verified on a 32-bit RH6.8. Travis seems happy too.
(Is it creating reports only on pull requests?)

Thanks,
Ram

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]

On 10/22/2016 9:26 AM, Amrani, Ram wrote:
> 
>> The only outstanding "real" issue I'm aware of is compilation in 32-bit
>> as reported by Travis CI. I have a patch ready for it but I cannot send it 
>> right now (it's Holiday and I'm away). I guess I will be able to pull it off
>> tonight (in 12 hours) or tomorrow morning.
> 
> I just created a pull request, earlier than I expected.
> The commit was verified on a 32-bit RH6.8. Travis seems happy too.
> (Is it creating reports only on pull requests?)
> 
> Thanks,
> Ram
> 

Thanks, merged.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: Introduction of libqedr to the Consolidated Userspace RDMA Library Repo

[Jason Gunthorpe]

On Sat, Oct 22, 2016 at 01:26:51PM +0000, Amrani, Ram wrote:

> I just created a pull request, earlier than I expected.
> The commit was verified on a 32-bit RH6.8. Travis seems happy too.
> (Is it creating reports only on pull requests?)

travis runs on pull requests and after each merge on the TOT.

It became horribly broken last friday and could not report anything.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html