From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jarod Wilson <jarod@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, Faisal Latif <faisal.latif@intel.com>,
Cliff Whickman <cpw@sgi.com>, Robin Holt <robinmholt@gmail.com>,
Jes Sorensen <jes@trained-monkey.org>,
Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>,
Antonio Quartulli <a@unstable.cc>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
MPT-FusionLinux.pdl@broadcom.com,
Sebastian Reichel <sre@kernel.org>,
Felipe Balbi <balbi@kernel.org>,
Arvid Brodin <arvid.brodin@alten.se>,
Remi Denis-Courmont <courmisch@gmail.com>
Subject: Re: [PATCH net-next v2 7/9] net: use core MTU range checking in misc drivers
Date: Sat, 22 Oct 2016 21:16:06 +0200 [thread overview]
Message-ID: <20161022211606.3b5d137d@kant> (raw)
In-Reply-To: <20161020175524.6184-8-jarod@redhat.com>
On Oct 20 Jarod Wilson wrote:
> firewire-net:
> - set min/max_mtu
> - remove fwnet_change_mtu
[...]
> --- a/drivers/firewire/net.c
> +++ b/drivers/firewire/net.c
[...]
> @@ -1478,9 +1467,10 @@ static int fwnet_probe(struct fw_unit *unit,
> * Use the RFC 2734 default 1500 octets or the maximum payload
> * as initial MTU
> */
> - max_mtu = (1 << (card->max_receive + 1))
> - - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE;
> - net->mtu = min(1500U, max_mtu);
> + net->max_mtu = (1 << (card->max_receive + 1))
> + - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE;
> + net->mtu = min(1500U, net->max_mtu);
> + net->min_mtu = ETH_MIN_MTU;
>
> /* Set our hardware address while we're at it */
> ha = (union fwnet_hwaddr *)net->dev_addr;
Please preserve the current behavior, i.e. do not enforce any particular
upper bound. (Especially none based on the local link layer controller's
max_receive parameter.)
BTW, after having read RFC 2734, RFC 3146, and the code, I am convinced
that net->mtu should be initialized to 1500, not less. But such a change
should be done in a separate patch.
--
Stefan Richter
-======----- =-=- =-==-
http://arcgraph.de/sr/
prev parent reply other threads:[~2016-10-22 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161019023333.15760-1-jarod@redhat.com>
2016-10-19 2:33 ` [PATCH net-next 6/6] net: use core MTU range checking in misc drivers Jarod Wilson
2016-10-19 14:37 ` Robin Holt
2016-10-19 16:05 ` Sabrina Dubroca
2016-10-19 22:38 ` Stefan Richter
2016-10-20 3:16 ` Jarod Wilson
[not found] ` <20161020031641.GJ18569-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-22 9:36 ` Stefan Richter
2016-10-22 18:51 ` Stefan Richter
[not found] ` <20161020175524.6184-1-jarod@redhat.com>
2016-10-20 17:55 ` [PATCH net-next v2 7/9] " Jarod Wilson
2016-10-21 6:52 ` Rémi Denis-Courmont
2016-10-21 16:22 ` Sebastian Reichel
[not found] ` <20161020175524.6184-8-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-22 7:17 ` [net-next,v2,7/9] " Sven Eckelmann
2016-10-22 19:16 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161022211606.3b5d137d@kant \
--to=stefanr@s5r6.in-berlin.de \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=a@unstable.cc \
--cc=arvid.brodin@alten.se \
--cc=balbi@kernel.org \
--cc=chaitra.basappa@broadcom.com \
--cc=courmisch@gmail.com \
--cc=cpw@sgi.com \
--cc=faisal.latif@intel.com \
--cc=jarod@redhat.com \
--cc=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=robinmholt@gmail.com \
--cc=sathya.prakash@broadcom.com \
--cc=sre@kernel.org \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).