* [PATCH] ibsim/Makefile: Add install rpath to linker
@ 2016-10-27 13:55 Ilya Nelkenbaum
[not found] ` <1477576531-29723-1-git-send-email-ilyan-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Ilya Nelkenbaum @ 2016-10-27 13:55 UTC (permalink / raw)
To: hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, ilyan-VPRAkNaXOzVWk0Htik3J/w
From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
ibsim/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ibsim/Makefile b/ibsim/Makefile
index 5d1ac62..ad94651 100644
--- a/ibsim/Makefile
+++ b/ibsim/Makefile
@@ -1,5 +1,7 @@
progs:=ibsim
+ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib"
+
-include ../defs.mk
all: $(progs)
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ibsim/Makefile: Add install rpath to linker
[not found] ` <1477576531-29723-1-git-send-email-ilyan-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2016-10-27 14:38 ` Leon Romanovsky
[not found] ` <20161027143810.GJ3617-2ukJVAZIZ/Y@public.gmane.org>
2016-10-27 15:00 ` Jason Gunthorpe
1 sibling, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2016-10-27 14:38 UTC (permalink / raw)
To: Ilya Nelkenbaum
Cc: hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, ilyan-VPRAkNaXOzVWk0Htik3J/w
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote:
> From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> Signed-off-by: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> ibsim/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
Against which tree did you base your code?
Thanks.
>
> diff --git a/ibsim/Makefile b/ibsim/Makefile
> index 5d1ac62..ad94651 100644
> --- a/ibsim/Makefile
> +++ b/ibsim/Makefile
> @@ -1,5 +1,7 @@
> progs:=ibsim
>
> +ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib"
> +
> -include ../defs.mk
>
> all: $(progs)
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ibsim/Makefile: Add install rpath to linker
[not found] ` <20161027143810.GJ3617-2ukJVAZIZ/Y@public.gmane.org>
@ 2016-10-27 14:50 ` Hal Rosenstock
0 siblings, 0 replies; 4+ messages in thread
From: Hal Rosenstock @ 2016-10-27 14:50 UTC (permalink / raw)
To: Leon Romanovsky, Ilya Nelkenbaum
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, ilyan-VPRAkNaXOzVWk0Htik3J/w
On 10/27/2016 10:38 AM, Leon Romanovsky wrote:
> On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote:
>> From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> Signed-off-by: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> ---
>> ibsim/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Against which tree did you base your code?
Upstream ibsim git repo is git://git.openfabrics.org/~halr/ibsim.git
so I assume Ilya's patch is against this repo.
-- Hal
>
> Thanks.
>
>>
>> diff --git a/ibsim/Makefile b/ibsim/Makefile
>> index 5d1ac62..ad94651 100644
>> --- a/ibsim/Makefile
>> +++ b/ibsim/Makefile
>> @@ -1,5 +1,7 @@
>> progs:=ibsim
>>
>> +ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib"
>> +
>> -include ../defs.mk
>>
>> all: $(progs)
>> --
>> 1.8.3.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ibsim/Makefile: Add install rpath to linker
[not found] ` <1477576531-29723-1-git-send-email-ilyan-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-10-27 14:38 ` Leon Romanovsky
@ 2016-10-27 15:00 ` Jason Gunthorpe
1 sibling, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2016-10-27 15:00 UTC (permalink / raw)
To: Ilya Nelkenbaum
Cc: hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, ilyan-VPRAkNaXOzVWk0Htik3J/w
On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote:
> From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
One should never open code rpath like this, it makes distros angry.
Use libtool or whatever.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-27 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-27 13:55 [PATCH] ibsim/Makefile: Add install rpath to linker Ilya Nelkenbaum
[not found] ` <1477576531-29723-1-git-send-email-ilyan-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-10-27 14:38 ` Leon Romanovsky
[not found] ` <20161027143810.GJ3617-2ukJVAZIZ/Y@public.gmane.org>
2016-10-27 14:50 ` Hal Rosenstock
2016-10-27 15:00 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox