Re: [PATCH rdma-core 1/7] libhns: Add initial main frame

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Thu, Oct 27, 2016 at 11:41:35AM +0800, oulijun wrote:

> when startup by DT, the content of device/modalias is
> of:NinfinibandT<NULL>Chisilicon,hns-roce-v1.  it is long and
> complex.

If you want to match the hardware then properly parsing the mod alias
is the right way to do it.

> the content of device/of_node/compatible is hisilicon,hns-roce-v1

No, it is more complex than that, future DTs may have a list for
instance, just a string match is not good enough

> when startup by APCI, the content of device/modalias is
> acpi:HISI00D1:

Also may be more complex..

>   if (ibv_read_sysfs-file(uverbs_sys_path, "device/vendor", value, sizeof(value)) > 0)
> 	...
>   if (ibv_read_sysfs-file(uverbs_sys_path, "device/vendor", value, sizeof(value)) > 0)
>  	...

You can also match PCI with modalias.

> > But I wonder if this isn't generically better to be
> > 
> >  last_dir(readlink("device/driver")) == "hns"
> > 

> I think it is not insteaded. because it will be find the hns in the
> path(device/driver)

I said readlink, which will return something like '../../../../bus/platform/drivers/hhns'

So just detect the driver is calld hhns and let the kernel deal with
figuring it out.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html