[PATCH] ibsim/Makefile: Add install rpath to linker

[PATCH] ibsim/Makefile: Add install rpath to linker

[Ilya Nelkenbaum]

From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Signed-off-by: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 ibsim/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ibsim/Makefile b/ibsim/Makefile
index 5d1ac62..ad94651 100644
--- a/ibsim/Makefile
+++ b/ibsim/Makefile
@@ -1,5 +1,7 @@
 progs:=ibsim
 
+ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib"
+
 -include ../defs.mk
 
 all: $(progs)
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ibsim/Makefile: Add install rpath to linker

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote:
> From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> Signed-off-by: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  ibsim/Makefile | 2 ++
>  1 file changed, 2 insertions(+)

Against which tree did you base your code?

Thanks.

>
> diff --git a/ibsim/Makefile b/ibsim/Makefile
> index 5d1ac62..ad94651 100644
> --- a/ibsim/Makefile
> +++ b/ibsim/Makefile
> @@ -1,5 +1,7 @@
>  progs:=ibsim
>
> +ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib"
> +
>  -include ../defs.mk
>
>  all: $(progs)
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ibsim/Makefile: Add install rpath to linker

[Hal Rosenstock]

On 10/27/2016 10:38 AM, Leon Romanovsky wrote:
> On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote:
>> From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> Signed-off-by: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> ---
>>  ibsim/Makefile | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Against which tree did you base your code?

Upstream ibsim git repo is git://git.openfabrics.org/~halr/ibsim.git
so I assume Ilya's patch is against this repo.

-- Hal

> 
> Thanks.
> 
>>
>> diff --git a/ibsim/Makefile b/ibsim/Makefile
>> index 5d1ac62..ad94651 100644
>> --- a/ibsim/Makefile
>> +++ b/ibsim/Makefile
>> @@ -1,5 +1,7 @@
>>  progs:=ibsim
>>
>> +ibsim_LDFLAGS = "-Wl,-rpath,\$$ORIGIN/../lib"
>> +
>>  -include ../defs.mk
>>
>>  all: $(progs)
>> --
>> 1.8.3.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ibsim/Makefile: Add install rpath to linker

[Jason Gunthorpe]

On Thu, Oct 27, 2016 at 04:55:31PM +0300, Ilya Nelkenbaum wrote:
> From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

One should never open code rpath like this, it makes distros angry.

Use libtool or whatever.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html