From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC ABI V5 07/10] IB/core: Support getting IOCTL header/SGEs from kernel space Date: Fri, 28 Oct 2016 08:21:38 -0700 Message-ID: <20161028152138.GA16421@infradead.org> References: <1477579398-6875-1-git-send-email-matanb@mellanox.com> <1477579398-6875-8-git-send-email-matanb@mellanox.com> <20161028065943.GA10418@infradead.org> <20161028151606.GN3617@leon.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161028151606.GN3617-2ukJVAZIZ/Y@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Christoph Hellwig , Matan Barak , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Ledford , Jason Gunthorpe , Sean Hefty , Christoph Lameter , Liran Liss , Haggai Eran , Majd Dibbiny , Tal Alon List-Id: linux-rdma@vger.kernel.org On Fri, Oct 28, 2016 at 06:16:06PM +0300, Leon Romanovsky wrote: > And it is indeed happen for new code. This magic is needed to allow legacy > write interface to be converted to new ioctl interface internally in > kernel. You just added these statements which are by defintion new code. Don't do that - create a clean kernel internal interface instead. The canonical one would be to only pass kernel pointers in the internal interface. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html