From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
Liran Liss <liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Tal Alon <talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [RFC ABI V5 07/10] IB/core: Support getting IOCTL header/SGEs from kernel space
Date: Fri, 28 Oct 2016 18:33:06 +0300 [thread overview]
Message-ID: <20161028153306.GO3617@leon.nu> (raw)
In-Reply-To: <20161028152138.GA16421-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]
On Fri, Oct 28, 2016 at 08:21:38AM -0700, Christoph Hellwig wrote:
> On Fri, Oct 28, 2016 at 06:16:06PM +0300, Leon Romanovsky wrote:
> > And it is indeed happen for new code. This magic is needed to allow legacy
> > write interface to be converted to new ioctl interface internally in
> > kernel.
>
> You just added these statements which are by defintion new code.
> Don't do that - create a clean kernel internal interface instead.
>
> The canonical one would be to only pass kernel pointers in the internal
> interface.
Just to summarize, to be sure that I understood you correctly.
--------- --------------------
| write | -> | conversion logic | ---
--------- -------------------- | ----------------------
-----> | internal interface |
--------- | ----------------------
| ioctl | ---------------------------
---------
Am I right?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-28 15:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 14:43 [RFC ABI V5 00/10] SG-based RDMA ABI Proposal Matan Barak
[not found] ` <1477579398-6875-1-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-10-27 14:43 ` [RFC ABI V5 01/10] RDMA/core: Refactor IDR to be per-device Matan Barak
[not found] ` <1477579398-6875-2-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-10-28 22:53 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373AB0A445F-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-30 9:13 ` Leon Romanovsky
2016-11-07 23:55 ` Jason Gunthorpe
[not found] ` <20161107235516.GE7002-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-09 9:34 ` Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 02/10] RDMA/core: Add support for custom types Matan Barak
[not found] ` <1477579398-6875-3-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-10-30 19:28 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373AB0A47BD-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-31 22:58 ` Matan Barak
[not found] ` <CAAKD3BDWyb10baLrDu=m_mYPB64i9OOPEPVYKtDo9zVbvMM-UA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-09 18:00 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373AB0A8000-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-11-09 18:50 ` Jason Gunthorpe
2016-11-10 8:29 ` Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 03/10] RDMA/core: Add new ioctl interface Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 04/10] RDMA/core: Add initialize and cleanup of common types Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 05/10] RDMA/core: Add uverbs types, actions, handlers and attributes Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 06/10] IB/mlx5: Implement common uverb objects Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 07/10] IB/core: Support getting IOCTL header/SGEs from kernel space Matan Barak
[not found] ` <1477579398-6875-8-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-10-28 6:59 ` Christoph Hellwig
[not found] ` <20161028065943.GA10418-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-10-28 15:16 ` Leon Romanovsky
[not found] ` <20161028151606.GN3617-2ukJVAZIZ/Y@public.gmane.org>
2016-10-28 15:21 ` Christoph Hellwig
[not found] ` <20161028152138.GA16421-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-10-28 15:33 ` Leon Romanovsky [this message]
[not found] ` <20161028153306.GO3617-2ukJVAZIZ/Y@public.gmane.org>
2016-10-28 15:37 ` Christoph Hellwig
[not found] ` <20161028153725.GA14166-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-10-28 15:46 ` Leon Romanovsky
[not found] ` <20161028154628.GP3617-2ukJVAZIZ/Y@public.gmane.org>
2016-10-30 8:48 ` Matan Barak
[not found] ` <CAAKD3BB0k1UxV2qO3SqAD_t1vM2pcduOXiz8aJ5c+JXAmq_aWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-08 0:43 ` Jason Gunthorpe
[not found] ` <20161108004351.GA32444-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-09 9:45 ` Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 08/10] IB/core: Implement compatibility layer for get context command Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 09/10] IB/core: Add create_qp command to the new ABI Matan Barak
2016-10-27 14:43 ` [RFC ABI V5 10/10] IB/core: Add modify_qp " Matan Barak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028153306.GO3617@leon.nu \
--to=leonro-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox