Re: [PATCH rdma-core 0/8] libpvrdma: userspace library for PVRDMA

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Fri, Nov 04, 2016 at 02:00:37PM -0700, Adit Ranadive wrote:
> I commented on most of the notes and I'll post a fix to address them.
> Do I have re-issue the pull request or would it pick it automatically
> after I push it?

No just keep pushing, Doug can squash everything into one commit when
applying.

> > The big item is that the shared ABI file must be byte for byte
> > identical to the kernel version, and it looks to me like it was
> > changed?
> > 
> > We still do not have a general solution to the need to add the header
> > struct in user space but not in kernel space, so you will need to
> > continue to get your enums from the kernel header but still have a
> > 'copy' with the modified structs.
> > 
> > Does that make sense?
> 
> Not entirely. You want me to keep the ABI file from the kernel in the
> fix up folder and also keep a file with the modified structs in
> providers/pvrdma?

Yes, and the file with the modified structs should include the kernel
header and duplicate it minimally. This will make it simpler for us to
eventually get rid of it.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html