Re: [PATCH rdma-core 1/7] libhns: Add initial main frame

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Wed, Nov 09, 2016 at 09:10:31PM +0800, oulijun wrote:
> ??? 2016/11/8 20:54, Leon Romanovsky ??????:
> > On Mon, Nov 07, 2016 at 04:15:32PM -0700, Jason Gunthorpe wrote:
> >> On Sat, Oct 29, 2016 at 09:16:25AM +0800, oulijun wrote:
> >>
> >>> We hope that the only one userspace library file named
> >>> libhns-rdmav2.so will be used for the different hardware
> >>> version(hip06, hip07, ...), because there are only little change
> >>> between their userspace drivers. So we need to distinguish hardware
> >>> version.
> >>
> >> I guess that makes sense, but you still need to be able to parse dt
> >> compatible strings that are lists.
> > 
> > IMHO, it can be easily done as follow up patches.
> > 
> Hi, Leon & Jason
>    We hope that the only one userspace library file named libhns-rdmav2.so will be used for the different hardware version(hip06, hip07, ...),
> because there are only little change between their userspace drivers. So we need to distinguish hardware version.
> We can't distinguish them if only matching driver name "hns_roce".

That is fine..

> 	if (ibv_read_sysfs_file(uverbs_sys_path, "device/of_node/compatible",
> 				value, sizeof(value)) > 0)
> 		for (i = 0; i < sizeof(dt_table) / sizeof(dt_table[0]); ++i)
> 			if (!strcmp(value, dt_table[i].compatible)) {

This isn't right, compatible can be a list, if I recall it is a null
separated list of names, you need to parse the list.

Again, it would much better to just parse modalias directly, and
better still to add some core libiverbs code to do that for all
drivers.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html