linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2 08/12] xprtrdma: Update documenting comment
Date: Fri, 18 Nov 2016 10:00:00 -0500	[thread overview]
Message-ID: <20161118150000.10592.47368.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20161118145547.10592.66470.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>

Clean up: If reset fails, FRMRs are no longer abandoned, rather
they are released immediately. Update the comment to reflect this.

Fixes: 2ffc871a574d ('xprtrdma: Release orphaned MRs immediately')
Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 net/sunrpc/xprtrdma/frwr_ops.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c
index 900dc40..47bed53 100644
--- a/net/sunrpc/xprtrdma/frwr_ops.c
+++ b/net/sunrpc/xprtrdma/frwr_ops.c
@@ -171,10 +171,6 @@
 }
 
 /* Reset of a single FRMR. Generate a fresh rkey by replacing the MR.
- *
- * There's no recovery if this fails. The FRMR is abandoned, but
- * remains in rb_all. It will be cleaned up when the transport is
- * destroyed.
  */
 static void
 frwr_op_recover_mr(struct rpcrdma_mw *mw)

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-11-18 15:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 14:58 [PATCH v2 00/12] client-side NFS/RDMA patches proposed for v4.10 Chuck Lever
     [not found] ` <20161118145547.10592.66470.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2016-11-18 14:59   ` [PATCH v2 01/12] xprtrdma: Cap size of callback buffer resources Chuck Lever
2016-11-18 14:59   ` [PATCH v2 02/12] xprtrdma: Make FRWR send queue entry accounting more accurate Chuck Lever
2016-11-18 14:59   ` [PATCH v2 03/12] xprtrdma: Support for SG_GAP devices Chuck Lever
2016-11-18 14:59   ` [PATCH v2 04/12] SUNRPC: Proper metric accounting when RPC is not transmitted Chuck Lever
2016-11-18 14:59   ` [PATCH v2 05/12] xprtrdma: Address coverity complaint about wait_for_completion() Chuck Lever
2016-11-18 14:59   ` [PATCH v2 06/12] xprtrdma: Avoid calls to ro_unmap_safe() Chuck Lever
2016-11-18 14:59   ` [PATCH v2 07/12] xprtrdma: Refactor FRMR invalidation Chuck Lever
2016-11-18 15:00   ` Chuck Lever [this message]
2016-11-18 15:00   ` [PATCH v2 09/12] xprtrdma: Squelch "max send, max recv" messages at connect time Chuck Lever
2016-11-18 15:00   ` [PATCH v2 10/12] xprtrdma: Shorten QP access error message Chuck Lever
2016-11-18 15:00   ` [PATCH v2 11/12] xprtrdma: Update dprintk in rpcrdma_count_chunks Chuck Lever
2016-11-18 15:00   ` [PATCH v2 12/12] xprtrdma: Relocate connection helper functions Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161118150000.10592.47368.stgit@manet.1015granger.net \
    --to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).