From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Valdis.Kletnieks@vt.edu
Cc: Dmitry Vyukov <dvyukov@google.com>,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, leon@kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller@googlegroups.com
Subject: Re: [PATCH] infiniband: remove WARN that is not kernel bug
Date: Sat, 19 Nov 2016 11:57:32 -0700 [thread overview]
Message-ID: <20161119185732.GF22775@obsidianresearch.com> (raw)
In-Reply-To: <164538.1479522162@turing-police.cc.vt.edu>
On Fri, Nov 18, 2016 at 09:22:42PM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Fri, 18 Nov 2016 12:24:37 +0100, Dmitry Vyukov said:
> > WARNINGs mean kernel bugs.
> > The one in ucma_write() points to user programming error
> > or a malicious attempt. This is not a kernel bug, remove it.
>
> > - if (WARN_ON_ONCE(!ib_safe_file_access(filp)))
> > + if (!ib_safe_file_access(filp))
> > return -EACCES;
>
> In that case, wouldn't this be better?
>
> if (!ib_safe_file_access(filp)) {
> printk_once("Process %d (%s) tried to do something hinky", pid, comm);
> return _EACCESS;
> }
>
> so the sysadmin becomes aware of the malicious attempt?
Yes please
Jason
next prev parent reply other threads:[~2016-11-19 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 11:24 [PATCH] infiniband: remove WARN that is not kernel bug Dmitry Vyukov
2016-11-19 2:22 ` Valdis.Kletnieks
2016-11-19 18:57 ` Jason Gunthorpe [this message]
[not found] ` <20161119185732.GF22775-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-21 10:19 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119185732.GF22775@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=dledford@redhat.com \
--cc=dvyukov@google.com \
--cc=hal.rosenstock@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).