From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 10/11] IB/IPoIB: Modify ipoib_get_net_dev_by_params to lookup gid table Date: Tue, 22 Nov 2016 14:20:57 -0700 Message-ID: <20161122212057.GB6484@obsidianresearch.com> References: <1479843532-47496-1-git-send-email-dasaratharaman.chandramouli@intel.com> <1479843532-47496-11-git-send-email-dasaratharaman.chandramouli@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1479843532-47496-11-git-send-email-dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dasaratharaman Chandramouli Cc: Ira Weiny , Don Hiatt , linux-rdma , Doug Ledford List-Id: linux-rdma@vger.kernel.org On Tue, Nov 22, 2016 at 02:38:51PM -0500, Dasaratharaman Chandramouli wrote: > ipoib_get_net_dev_by_params compares incoming gid with local_gid > which is gid at index 0 of the gid table. OPA devices using larger > LIDs may have a different GID format than whats setup in the local_gid > field. Do a search of the gid table in those cases. Sorry, NAK, the incoming GID has to exactly match what is in IPoIB LLADDR, you can't do this or it breaks how the virtualization stuff is supposed to work with gid aliases. I'm skeptical about the other ipoib patch as well since ipoib should be dealing natively with 32 bit lids, I think you need to fix the path record stuff too instead of opening coding that in ipoib. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html