Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

Jason Gunthorpe
2016-11-19T19:04:45Z

On Fri, Nov 18, 2016 at 02:42:10PM -0800, Vishwanathapura, Niranjana wrote:
> +HFI-VNIC DRIVER
> +M: Dennis Dalessandro <dennis.dalessandro@intel.com>
> +M: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> +L: linux-rdma@vger.kernel.org
> +S: Supported
> +F: drivers/infiniband/sw/intel/vnic

This is either a net driver or a ULP, no idea why it should go in this
directory!?

It sounds like an ethernet driver, so you should probably put it
there...

> +/* hfi_vnic_bus_init - initialize the hfi vnic bus drvier */
> +static int hfi_vnic_bus_init(void)
> +{
> + int rc;
> +
> + ida_init(&hfi_vnic_ctrl_ida);
> + idr_init(&hfi_vnic_idr);
> +
> + rc = bus_register(&hfi_vnic_bus);

Why on earth do we need this? Didn't I give you enough grief for the
psm stuff and now you want to create an entire subystem hidden away!?

Use some netlink scheme to control your vnic like the rest of the net
stack..

Jason