From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH v3] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc Date: Tue, 29 Nov 2016 21:58:12 +0200 Message-ID: <20161129195811.GA4221@yuval-lap.uk.oracle.com> References: <20161129194611.GA4088@jordon-HP-15-Notebook-PC> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161129194611.GA4088@jordon-HP-15-Notebook-PC> Sender: netdev-owner@vger.kernel.org To: Souptick Joarder Cc: sergei.shtylyov@cogentembedded.com, yishaih@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, sahu.rameshwar73@gmail.com List-Id: linux-rdma@vger.kernel.org On Wed, Nov 30, 2016 at 01:16:12AM +0530, Souptick Joarder wrote: > In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be > replaced by pci_pool_zalloc() > > Signed-off-by: Souptick joarder > --- > v3: > - Fixed alignment issues You mean remove extra empty line? Reviewed-by: Yuval Shaia > > v2: > - Address comment from sergei > Alignment was not proper > > drivers/net/ethernet/mellanox/mlx4/cmd.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c > index e36bebc..a49072b4 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c > +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c > @@ -2679,15 +2679,13 @@ struct mlx4_cmd_mailbox *mlx4_alloc_cmd_mailbox(struct mlx4_dev *dev) > if (!mailbox) > return ERR_PTR(-ENOMEM); > > - mailbox->buf = pci_pool_alloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL, > - &mailbox->dma); > + mailbox->buf = pci_pool_zalloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL, > + &mailbox->dma); > if (!mailbox->buf) { > kfree(mailbox); > return ERR_PTR(-ENOMEM); > } > > - memset(mailbox->buf, 0, MLX4_MAILBOX_SIZE); > - > return mailbox; > } > EXPORT_SYMBOL_GPL(mlx4_alloc_cmd_mailbox); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html