From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 01/10] IB/core: Add raw packet protocol Date: Wed, 30 Nov 2016 10:08:30 -0700 Message-ID: <20161130170830.GA17512@obsidianresearch.com> References: <1480258296-27032-1-git-send-email-leon@kernel.org> <1480258296-27032-2-git-send-email-leon@kernel.org> <20161128170056.GC28381@obsidianresearch.com> <05bd01d2499a$1c75f750$5561e5f0$@opengridcomputing.com> <5927e04b-42ec-52c1-88a3-456cc4409334@talpey.com> <20161130163949.GC24639@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Liran Liss Cc: Tom Talpey , Doug Ledford , Steve Wise , 'Leon Romanovsky' , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , 'Steve Wise' , 'Mike Marciniszyn' , 'Dennis Dalessandro' , 'Lijun Ou' , "'Wei Hu(Xavier)'" , 'Faisal Latif' , Yishai Hadas , 'Selvin Xavier' , 'Devesh Sharma' , 'Mitesh Ahuja' , 'Christian Benvenuti' , 'Dave Goodell' , Moni Shoua , Or Gerlitz List-Id: linux-rdma@vger.kernel.org On Wed, Nov 30, 2016 at 05:01:32PM +0000, Liran Liss wrote: > > From: Jason Gunthorpe [mailto:jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org] > > > > > > Exactly. If/when such devices appear, we would need to extend > > > connection management to specify the protocol, rather than infer it > > > from the port space. > > > > We support that perfectly today as long as the port creates two 'struct > > ib_devices'. Anything else will require some kind of changes to libibverb's API to > > specify the AH style. > > > > rdmacm would still have to choose between these ib_devices somehow Each ib_device is either iwarp or rocee, the rdma cm would route iwarp stuff to the iwarp one and rocee stuff to the rocee one. Not really a problem with today's architecture. > - this doesn't change anything. Also, AHs are already > port-specific. So, I don't see any issue in this regard. The current scheme infers the protocol of the AH from the current configuration of the port, which is a crazy API when the port's protocol can change on the fly. > In any case, we have millions of multi-port devices that can use > different link types deployed. This is the specification, and more > such devices could appear in the future. We cannot change the > device model. Of course we can change how they are modeled in Linux, it is just software. > No doubt that the new ABI would be a lot more flexible and > self-describing. But it would take a while until we port everything > to use it. So, generally, I don't see any problem using the current > extensibility capabilities to support useful semantics. Perhaps a moritorium on some changes to the current uAPI will encourage the new one to get finished :P Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html