[PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool

public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool_zalloc
@ 2016-12-01 18:41 Souptick Joarder
  2016-12-01 19:13 ` Yuval Shaia
  2016-12-14 19:03 ` Doug Ledford
  0 siblings, 2 replies; 5+ messages in thread
From: Souptick Joarder @ 2016-12-01 18:41 UTC (permalink / raw)
  To: yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA,
	dledford-H+wXaHxf7aLQT0dZR+AlfA,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	sahu.rameshwar73-Re5JQEeQqe8AvxtiuMwx3w

In mthca_create_ah(), pci_pool_alloc() followed by memset will be
replaced by pci_pool_zalloc()

Signed-off-by: Souptick joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
v2:
  - Alignment changes
  - Remove empty lines

 drivers/infiniband/hw/mthca/mthca_av.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/mthca/mthca_av.c b/drivers/infiniband/hw/mthca/mthca_av.c
index bcac294..c9f0f36 100644
--- a/drivers/infiniband/hw/mthca/mthca_av.c
+++ b/drivers/infiniband/hw/mthca/mthca_av.c
@@ -186,8 +186,8 @@ int mthca_create_ah(struct mthca_dev *dev,

 on_hca_fail:
 	if (ah->type == MTHCA_AH_PCI_POOL) {
-		ah->av = pci_pool_alloc(dev->av_table.pool,
-					GFP_ATOMIC, &ah->avdma);
+		ah->av = pci_pool_zalloc(dev->av_table.pool,
+					 GFP_ATOMIC, &ah->avdma);
 		if (!ah->av)
 			return -ENOMEM;

@@ -196,8 +196,6 @@ int mthca_create_ah(struct mthca_dev *dev,

 	ah->key = pd->ntmr.ibmr.lkey;

-	memset(av, 0, MTHCA_AV_SIZE);
-
 	av->port_pd = cpu_to_be32(pd->pd_num | (ah_attr->port_num << 24));
 	av->g_slid  = ah_attr->src_path_bits;
 	av->dlid    = cpu_to_be16(ah_attr->dlid);
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool_zalloc
  2016-12-01 18:41 [PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool_zalloc Souptick Joarder
@ 2016-12-01 19:13 ` Yuval Shaia
  2016-12-05  6:24   ` Souptick Joarder
  2016-12-14 19:03 ` Doug Ledford
  1 sibling, 1 reply; 5+ messages in thread
From: Yuval Shaia @ 2016-12-01 19:13 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	sahu.rameshwar73-Re5JQEeQqe8AvxtiuMwx3w

Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

On Fri, Dec 02, 2016 at 12:11:59AM +0530, Souptick Joarder wrote:
> In mthca_create_ah(), pci_pool_alloc() followed by memset will be
> replaced by pci_pool_zalloc()
> 
> Signed-off-by: Souptick joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> v2:
>   - Alignment changes
>   - Remove empty lines
> 
>  drivers/infiniband/hw/mthca/mthca_av.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mthca/mthca_av.c b/drivers/infiniband/hw/mthca/mthca_av.c
> index bcac294..c9f0f36 100644
> --- a/drivers/infiniband/hw/mthca/mthca_av.c
> +++ b/drivers/infiniband/hw/mthca/mthca_av.c
> @@ -186,8 +186,8 @@ int mthca_create_ah(struct mthca_dev *dev,
> 
>  on_hca_fail:
>  	if (ah->type == MTHCA_AH_PCI_POOL) {
> -		ah->av = pci_pool_alloc(dev->av_table.pool,
> -					GFP_ATOMIC, &ah->avdma);
> +		ah->av = pci_pool_zalloc(dev->av_table.pool,
> +					 GFP_ATOMIC, &ah->avdma);
>  		if (!ah->av)
>  			return -ENOMEM;
> 
> @@ -196,8 +196,6 @@ int mthca_create_ah(struct mthca_dev *dev,
> 
>  	ah->key = pd->ntmr.ibmr.lkey;
> 
> -	memset(av, 0, MTHCA_AV_SIZE);
> -
>  	av->port_pd = cpu_to_be32(pd->pd_num | (ah_attr->port_num << 24));
>  	av->g_slid  = ah_attr->src_path_bits;
>  	av->dlid    = cpu_to_be16(ah_attr->dlid);
> --
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool_zalloc
  2016-12-01 19:13 ` Yuval Shaia
@ 2016-12-05  6:24   ` Souptick Joarder
       [not found]     ` <CAFqt6zarZHK3+7QH3tfuHXr2YtV_bL8WavKuPt97+YaqQoB=1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Souptick Joarder @ 2016-12-05  6:24 UTC (permalink / raw)
  To: Yuval Shaia
  Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w, Hal Rosenstock,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA, Rameshwar Sahu

Any further comment on this patch?

On Fri, Dec 2, 2016 at 12:43 AM, Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> On Fri, Dec 02, 2016 at 12:11:59AM +0530, Souptick Joarder wrote:
>> In mthca_create_ah(), pci_pool_alloc() followed by memset will be
>> replaced by pci_pool_zalloc()
>>
>> Signed-off-by: Souptick joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> v2:
>>   - Alignment changes
>>   - Remove empty lines
>>
>>  drivers/infiniband/hw/mthca/mthca_av.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/mthca/mthca_av.c b/drivers/infiniband/hw/mthca/mthca_av.c
>> index bcac294..c9f0f36 100644
>> --- a/drivers/infiniband/hw/mthca/mthca_av.c
>> +++ b/drivers/infiniband/hw/mthca/mthca_av.c
>> @@ -186,8 +186,8 @@ int mthca_create_ah(struct mthca_dev *dev,
>>
>>  on_hca_fail:
>>       if (ah->type == MTHCA_AH_PCI_POOL) {
>> -             ah->av = pci_pool_alloc(dev->av_table.pool,
>> -                                     GFP_ATOMIC, &ah->avdma);
>> +             ah->av = pci_pool_zalloc(dev->av_table.pool,
>> +                                      GFP_ATOMIC, &ah->avdma);
>>               if (!ah->av)
>>                       return -ENOMEM;
>>
>> @@ -196,8 +196,6 @@ int mthca_create_ah(struct mthca_dev *dev,
>>
>>       ah->key = pd->ntmr.ibmr.lkey;
>>
>> -     memset(av, 0, MTHCA_AV_SIZE);
>> -
>>       av->port_pd = cpu_to_be32(pd->pd_num | (ah_attr->port_num << 24));
>>       av->g_slid  = ah_attr->src_path_bits;
>>       av->dlid    = cpu_to_be16(ah_attr->dlid);
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <CAFqt6zarZHK3+7QH3tfuHXr2YtV_bL8WavKuPt97+YaqQoB=1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]

* Re: [PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool_zalloc
       [not found]     ` <CAFqt6zarZHK3+7QH3tfuHXr2YtV_bL8WavKuPt97+YaqQoB=1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-12-12  4:45       ` Souptick Joarder
  0 siblings, 0 replies; 5+ messages in thread
From: Souptick Joarder @ 2016-12-12  4:45 UTC (permalink / raw)
  To: Yuval Shaia
  Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w, Hal Rosenstock,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA, Rameshwar Sahu

On Mon, Dec 5, 2016 at 11:54 AM, Souptick Joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Any further comment on this patch?
>
> On Fri, Dec 2, 2016 at 12:43 AM, Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
>> Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>>
>> On Fri, Dec 02, 2016 at 12:11:59AM +0530, Souptick Joarder wrote:
>>> In mthca_create_ah(), pci_pool_alloc() followed by memset will be
>>> replaced by pci_pool_zalloc()
>>>
>>> Signed-off-by: Souptick joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> ---
>>> v2:
>>>   - Alignment changes
>>>   - Remove empty lines
>>>
>>>  drivers/infiniband/hw/mthca/mthca_av.c | 6 ++----
>>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/infiniband/hw/mthca/mthca_av.c b/drivers/infiniband/hw/mthca/mthca_av.c
>>> index bcac294..c9f0f36 100644
>>> --- a/drivers/infiniband/hw/mthca/mthca_av.c
>>> +++ b/drivers/infiniband/hw/mthca/mthca_av.c
>>> @@ -186,8 +186,8 @@ int mthca_create_ah(struct mthca_dev *dev,
>>>
>>>  on_hca_fail:
>>>       if (ah->type == MTHCA_AH_PCI_POOL) {
>>> -             ah->av = pci_pool_alloc(dev->av_table.pool,
>>> -                                     GFP_ATOMIC, &ah->avdma);
>>> +             ah->av = pci_pool_zalloc(dev->av_table.pool,
>>> +                                      GFP_ATOMIC, &ah->avdma);
>>>               if (!ah->av)
>>>                       return -ENOMEM;
>>>
>>> @@ -196,8 +196,6 @@ int mthca_create_ah(struct mthca_dev *dev,
>>>
>>>       ah->key = pd->ntmr.ibmr.lkey;
>>>
>>> -     memset(av, 0, MTHCA_AV_SIZE);
>>> -
>>>       av->port_pd = cpu_to_be32(pd->pd_num | (ah_attr->port_num << 24));
>>>       av->g_slid  = ah_attr->src_path_bits;
>>>       av->dlid    = cpu_to_be16(ah_attr->dlid);
>>> --
>>> 1.9.1
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Any comment on this patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool_zalloc
  2016-12-01 18:41 [PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool_zalloc Souptick Joarder
  2016-12-01 19:13 ` Yuval Shaia
@ 2016-12-14 19:03 ` Doug Ledford
  1 sibling, 0 replies; 5+ messages in thread
From: Doug Ledford @ 2016-12-14 19:03 UTC (permalink / raw)
  To: Souptick Joarder, yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	sahu.rameshwar73-Re5JQEeQqe8AvxtiuMwx3w


[-- Attachment #1.1: Type: text/plain, Size: 538 bytes --]

On 12/1/2016 1:41 PM, Souptick Joarder wrote:
> In mthca_create_ah(), pci_pool_alloc() followed by memset will be
> replaced by pci_pool_zalloc()
> 
> Signed-off-by: Souptick joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> v2:
>   - Alignment changes
>   - Remove empty lines
> 
>  drivers/infiniband/hw/mthca/mthca_av.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Thanks, applied.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-12-14 19:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-01 18:41 [PATCH v2] infiniband: mthca: Replace pci_pool_alloc by pci_pool_zalloc Souptick Joarder
2016-12-01 19:13 ` Yuval Shaia
2016-12-05  6:24   ` Souptick Joarder
     [not found]     ` <CAFqt6zarZHK3+7QH3tfuHXr2YtV_bL8WavKuPt97+YaqQoB=1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-12  4:45       ` Souptick Joarder
2016-12-14 19:03 ` Doug Ledford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox