From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH 5/5] mlx5, calc_sq_size(): Make a debug message more informative Date: Tue, 6 Dec 2016 16:31:59 +0200 Message-ID: <20161206143159.GB3437@mtr-leonro.local> References: <9ff07804-492c-c67a-e729-b31e0f863027@sandisk.com> <4387aa0f-5097-d456-eee2-b480dfa5af87@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Return-path: Content-Disposition: inline In-Reply-To: <4387aa0f-5097-d456-eee2-b480dfa5af87-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: Doug Ledford , Eli Cohen , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Mon, Dec 05, 2016 at 05:19:52PM -0800, Bart Van Assche wrote: > Make it clear that qp->sq.wqe_cnt is not the number of WQEs. > > Signed-off-by: Bart Van Assche > Cc: Eli Cohen Thanks, Acked-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx5/qp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c > index b2c6c13d44ac..735b8aadb84c 100644 > --- a/drivers/infiniband/hw/mlx5/qp.c > +++ b/drivers/infiniband/hw/mlx5/qp.c > @@ -381,7 +381,8 @@ static int calc_sq_size(struct mlx5_ib_dev *dev, struct ib_qp_init_attr *attr, > wq_size = roundup_pow_of_two(attr->cap.max_send_wr * wqe_size); > qp->sq.wqe_cnt = wq_size / MLX5_SEND_WQE_BB; > if (qp->sq.wqe_cnt > (1 << MLX5_CAP_GEN(dev->mdev, log_max_qp_sz))) { > - mlx5_ib_dbg(dev, "wqe count(%d) exceeds limits(%d)\n", > + mlx5_ib_dbg(dev, "send queue size (%d * %d / %d -> %d) exceeds limits(%d)\n", > + attr->cap.max_send_wr, wqe_size, MLX5_SEND_WQE_BB, > qp->sq.wqe_cnt, > 1 << MLX5_CAP_GEN(dev->mdev, log_max_qp_sz)); > return -ENOMEM; > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html