From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 01/10] IB/core: Add raw packet protocol Date: Wed, 7 Dec 2016 15:40:44 -0700 Message-ID: <20161207224044.GA23093@obsidianresearch.com> References: <1828884A29C6694DAF28B7E6B8A82373AB0BA1B7@ORSMSX109.amr.corp.intel.com> <1828884A29C6694DAF28B7E6B8A82373AB0BA68E@ORSMSX109.amr.corp.intel.com> <20161205171013.GA27784@obsidianresearch.com> <20161206213938.GC647@obsidianresearch.com> <1828884A29C6694DAF28B7E6B8A82373AB0BBEC7@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford Cc: "Hefty, Sean" , Or Gerlitz , Steve Wise , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Liran Liss , Matan Barak , Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Wed, Dec 07, 2016 at 05:06:24PM -0500, Doug Ledford wrote: > On 12/6/2016 5:13 PM, Hefty, Sean wrote: > >> I've already proposed disallowing multiprotocol struct ib_devices. > > > > My preference is to discontinue attempts at associating a protocol with the device. A device could implement a dozen protocols in software. Transports belong to QPs or cm ids, not devices. Each rdma_cm_id should be associated with a specific cm/transport directly, rather than indirectly selecting one based on the bound . > > > > If an app wants a specific transport type for a QP, why doesn't it just try to open one and see if the call fails? > > I tend to agree with Sean on this. And to answer Or's question from a > couple emails back, I'm inclined to just take the last three patches for > now while we work out a better idea of how everything here should be > done on the first seven patches. Well in that case, we should work toward getting rid of 'struct ib_device' - it is the cause of so much of this trouble. A port-focused model like the netstack uses is overall saner.. We can figure out some other way to model what ports can be shared within a PD, ideally something that works better for rxe.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html