Re: [PATCH v2 03/11] IB/core: Change ah_attr.dlid from 16 to 32 bits

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

On Tue, Nov 22, 2016 at 02:38:44PM -0500, Dasaratharaman Chandramouli wrote:
> dlid field in ah_attr is increased to 32 bits. This
> enables core components to use the larger addresses if needed.
> The user ABI is unchanged and userspace applications can use
> 16 bit lids when creating and modifying address handles.
> 
> Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
> Signed-off-by: Don Hiatt <don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---

<...>

> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index 52216f6..294d3ed 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -814,7 +814,7 @@ struct ib_mr_status {
>  
>  struct ib_ah_attr {
>  	struct ib_global_route	grh;
> -	u16			dlid;
> +	u32			dlid;
>  	u8			sl;
>  	u8			src_path_bits;
>  	u8			static_rate;

It looks like this structure can be reshuffled. Can you run pahole on it, please?

Thanks

> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]