From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [bug report] IB/mlx5: Support IB_WR_REG_SIG_MR
Date: Mon, 12 Dec 2016 12:33:55 +0300 [thread overview]
Message-ID: <20161212090910.GS8244@mwanda> (raw)
In-Reply-To: <20161211092326.GA4479-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Sun, Dec 11, 2016 at 11:23:26AM +0200, Leon Romanovsky wrote:
> > 3624 case IB_SIG_TYPE_T10_DIF:
> > 3625 psv_seg->transient_sig = cpu_to_be32(domain->sig.dif.bg << 16 |
> > 3626 domain->sig.dif.app_tag);
> > 3627 psv_seg->ref_tag = cpu_to_be32(domain->sig.dif.ref_tag);
> > 3628 break;
> > 3629 default:
> > 3630 pr_err("Bad signature type given.\n");
> > 3631 return 1;
> >
> > Why do we return 1 here instead of a negative error code?
>
> Yes, probably better to return something like EINVAL, instead of 1.
> do you want us to handle it?
>
Yes, please.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-12 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 9:20 [bug report] IB/mlx5: Support IB_WR_REG_SIG_MR Dan Carpenter
[not found] ` <20161209092044.GA4640-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2016-12-11 9:23 ` Leon Romanovsky
[not found] ` <20161211092326.GA4479-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-12 9:33 ` Dan Carpenter [this message]
2016-12-12 12:52 ` Leon Romanovsky
[not found] ` <20161212125205.GB6503-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-12 14:34 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212090910.GS8244@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox