From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH V2 08/10] i40iw: Control debug error prints using env variable Date: Wed, 14 Dec 2016 15:41:22 -0700 Message-ID: <20161214224122.GB9986@obsidianresearch.com> References: <1481306104-19352-1-git-send-email-tatyana.e.nikolova@intel.com> <1481306104-19352-9-git-send-email-tatyana.e.nikolova@intel.com> <20161210143421.GC2521@mtr-leonro.local> <13AA599688F47243B14FCFCCC2C803BB10AC7081@fmsmsx104.amr.corp.intel.com> <20161214171111.GA4521@mtr-leonro.local> <20161214212103.GA6947@obsidianresearch.com> <57fa42c9-5ef0-c6f5-f7fd-88ec5948d387@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <57fa42c9-5ef0-c6f5-f7fd-88ec5948d387-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford Cc: Leon Romanovsky , "Nikolova, Tatyana E" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Wed, Dec 14, 2016 at 05:36:26PM -0500, Doug Ledford wrote: > > I'm not sure I agree at all with what mlx5 is doing with tuning > > parameters via env vars :\ > > Options (not necessarily tuning though) have long been enabled via > env Sure, I was more concerned about using env vars for tuning. Setting log level/etc seems OK Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html