From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH V2 08/10] i40iw: Control debug error prints using env variable Date: Thu, 15 Dec 2016 11:50:34 -0700 Message-ID: <20161215185034.GB16552@obsidianresearch.com> References: <1481306104-19352-1-git-send-email-tatyana.e.nikolova@intel.com> <1481306104-19352-9-git-send-email-tatyana.e.nikolova@intel.com> <20161210143421.GC2521@mtr-leonro.local> <13AA599688F47243B14FCFCCC2C803BB10AC7081@fmsmsx104.amr.corp.intel.com> <20161214171111.GA4521@mtr-leonro.local> <20161214212103.GA6947@obsidianresearch.com> <20161215064807.GB811@mtr-leonro.local> <20161215165420.GA3264@obsidianresearch.com> <20161215183537.GH811@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161215183537.GH811-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: "Nikolova, Tatyana E" , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Thu, Dec 15, 2016 at 08:35:37PM +0200, Leon Romanovsky wrote: > I had in mind much simplier infrastucture, just add pr_debug(..) call > and allow every provider to place in any place in their code. I think the bitmask thing has to be hoisted too. > My main point is that I want to see all ENV variables in one place. Why? I really don't want to see util/ files include provider headers, for instance, so I don't like your SET() macro idea.. At this point I'd settle for having all ENV vars *documented* in one place :( Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html