Re: [PATCH] i40iw: Set 128B as the only supported RQ WQE size

Leon Romanovsky
2016-12-20T13:42:03Z

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

On Tue, Dec 20, 2016 at 12:44:04PM +0000, Tung, Chien Tin wrote:
>
>
> > -----Original Message-----
> > From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Leon Romanovsky
> > Sent: Tuesday, December 20, 2016 5:24 AM
> > To: Orosco, Henry <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; e1000-
> > rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org; Tung, Chien Tin <chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Subject: Re: [PATCH] i40iw: Set 128B as the only supported RQ WQE size
> >
> > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_ucontext.h
> > > b/drivers/infiniband/hw/i40iw/i40iw_ucontext.h
> > > index 12acd68..57d3f1d 100644
> > > --- a/drivers/infiniband/hw/i40iw/i40iw_ucontext.h
> > > +++ b/drivers/infiniband/hw/i40iw/i40iw_ucontext.h
> > > @@ -39,8 +39,8 @@
> > >
> > > #include <linux/types.h>
> > >
> > > -#define I40IW_ABI_USERSPACE_VER 4
> > > -#define I40IW_ABI_KERNEL_VER 4
> > > +#define I40IW_ABI_VER 5
> > > +
> >
> > Why did you remove defines and move to use constants "4" and "5" instead?
> [Chien Tin Tung] This is the ABI version change, did you read the commit message? Two defines were not necessary.
>

Thank you Chian Tin Tung for your informative answer and yes, I read commit message.

If you think that these defines are not needed, so can you please remove
the code which uses hardcoded "case 4" and "case 5"?

Or maybe they still needed and should be renamed?

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]