RE: [PATCH] i40iw: Set 128B as the only supported RQ WQE size

Tung, Chien Tin
2016-12-20T14:46:30Z

> -----Original Message-----
> From: Leon Romanovsky [mailto:leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org]
> Sent: Tuesday, December 20, 2016 7:42 AM
> To: Tung, Chien Tin <chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Orosco, Henry <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>; dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org;
> linux- rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> Subject: Re: [PATCH] i40iw: Set 128B as the only supported RQ WQE size
>
> On Tue, Dec 20, 2016 at 12:44:04PM +0000, Tung, Chien Tin wrote:
> >
> >
> > > -----Original Message-----
> > > From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> > > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Leon Romanovsky
> > > Sent: Tuesday, December 20, 2016 5:24 AM
> > > To: Orosco, Henry <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; e1000-
> > > rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org; Tung, Chien Tin
> > > <chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Subject: Re: [PATCH] i40iw: Set 128B as the only supported RQ WQE
> > > size
> > >
> > > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_ucontext.h
> > > > b/drivers/infiniband/hw/i40iw/i40iw_ucontext.h
> > > > index 12acd68..57d3f1d 100644
> > > > --- a/drivers/infiniband/hw/i40iw/i40iw_ucontext.h
> > > > +++ b/drivers/infiniband/hw/i40iw/i40iw_ucontext.h
> > > > @@ -39,8 +39,8 @@
> > > >
> > > > #include <linux/types.h>
> > > >
> > > > -#define I40IW_ABI_USERSPACE_VER 4
> > > > -#define I40IW_ABI_KERNEL_VER 4
> > > > +#define I40IW_ABI_VER 5
> > > > +
> > >
> > > Why did you remove defines and move to use constants "4" and "5"
> instead?
> > [Chien Tin Tung] This is the ABI version change, did you read the
> > commit
> message? Two defines were not necessary.
> >
>
> Thank you Chian Tin Tung for your informative answer and yes, I read
> commit message.
>
> If you think that these defines are not needed, so can you please
> remove the code which uses hardcoded "case 4" and "case 5"?
[Chien Tin Tung] Those are explicit checks against a particular ABI
version and it is clearer to use the numbers rather than some define.

>
> Or maybe they still needed and should be renamed?
[Chien Tin Tung] They are not needed. Before we were checking against
one version and one version only. Now we are making the provider library
and driver backward compatible. All we need is one define to specify current
ABI version.

Chien