Re: [PATCH] i40iw: Set 128B as the only supported RQ WQE size

Yuval Shaia
2016-12-20T17:30:45Z

On Tue, Dec 20, 2016 at 10:41:18AM -0600, Henry Orosco wrote:
> > >
> > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > index 392f783..98923a8 100644
> > > --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > @@ -358,13 +358,16 @@ void i40iw_qp_add_qos(struct i40iw_sc_qp *qp)
> > > * @dev: sc device struct
> > > * @pd: sc pd ptr
> > > * @pd_id: pd_id for allocated pd
> > > + * @abi_ver: ABI version from user context, -1 if not valid
> > > */
> > > static void i40iw_sc_pd_init(struct i40iw_sc_dev *dev,
> > > struct i40iw_sc_pd *pd,
> > > - u16 pd_id)
> > > + u16 pd_id,
> > > + int abi_ver)
> >
> > No need for new line here
> >
>
> Not sure what you mean here.

>From code-style perspective "u16 pd_id," and "int abi_ver" can be on one line.

>
> > > {
> > > pd->size = sizeof(*pd);
> > > pd->pd_id = pd_id;
> > > + pd->abi_ver = abi_ver;
> > > pd->dev = dev;
> > > }