From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH v2 infiniband-diags] ibdiag_common.c: Disambiguate link speed when QDR and could be FDR10 Date: Tue, 20 Dec 2016 17:04:18 +0200 Message-ID: <20161220150418.GB16038@yuval-lap> References: <094d3fd9-a478-ce30-b2de-8983c783c411@dev.mellanox.co.il> <20161220104149.GC7351@yuval-lap.uk.oracle.com> <20161220144247.GA16038@yuval-lap> <0797688e-b9ab-78d5-71d1-1b796589ac80@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <0797688e-b9ab-78d5-71d1-1b796589ac80-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock Cc: "Weiny, Ira" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Dec 20, 2016 at 10:01:46AM -0500, Hal Rosenstock wrote: > On 12/20/2016 9:42 AM, Yuval Shaia wrote: > > On Tue, Dec 20, 2016 at 07:31:59AM -0500, Hal Rosenstock wrote: > >> On 12/20/2016 5:41 AM, Yuval Shaia wrote: > >>> On Mon, Dec 19, 2016 at 05:25:11PM -0500, Hal Rosenstock wrote: > >>>> > >>>> Rather than printing "Could be FDR10", print > >>>> "Could be FDR10 (Found link at QDR but expected speed is FDR10)" > >>>> for this case. > >>>> > >>>> Confusion is with words "Could be" and fact that both > >>>> QDR and FDR10 are both 10.0 Gbps. > >>>> > >>>> Signed-off-by: Hal Rosenstock > >>>> --- > >>>> Change since v1: > >>>> Preserved original "Could be FDR10" so can grep for "Could be" > >>>> along with adding new language. > >>>> > >>>> src/ibdiag_common.c | 10 ++++++++-- > >>>> 1 file changed, 8 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/src/ibdiag_common.c b/src/ibdiag_common.c > >>>> index f74eed4..ad8551f 100644 > >>>> --- a/src/ibdiag_common.c > >>>> +++ b/src/ibdiag_common.c > >>>> @@ -814,8 +814,14 @@ check_ext_speed: > >>>> > >>>> check_fdr10_active: > >>>> if ((mad_get_field(port->ext_info, 0, > >>>> - IB_MLNX_EXT_PORT_LINK_SPEED_ACTIVE_F) & FDR10) == 0) > >>>> - snprintf(speed_msg, msg_size, "Could be FDR10"); > >>>> + IB_MLNX_EXT_PORT_LINK_SPEED_ACTIVE_F) & FDR10) == 0) { > >>>> + /* Special case QDR to try to avoid confusion with FDR10 */ > >>>> + if (mad_get_field(port->info, 0, IB_PORT_LINK_SPEED_ACTIVE_F) == 4) > > > > Should this "4" be #define? > > I think that such defines belong in the MAD libraries/headers but > unfortunately are missing. Suggesting to add it as (at least for me) 4 does not tell anything. > > >>>> + snprintf(speed_msg, msg_size, > >>>> + "Could be FDR10 (Found link at QDR but expected speed is FDR10)"); > >>>> + else > >>>> + snprintf(speed_msg, msg_size, "Could be FDR10"); > >>>> + } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html