From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Henry Orosco <henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"Tung,
Chien Tin"
<chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i40iw: Set 128B as the only supported RQ WQE size
Date: Tue, 20 Dec 2016 19:30:45 +0200 [thread overview]
Message-ID: <20161220173044.GA3677@yuval-lap> (raw)
In-Reply-To: <20161220164118.GA91636-ZmvEvTIhtuUfyugFOqMDN/ooFf0ArEBIu+b9c/7xato@public.gmane.org>
On Tue, Dec 20, 2016 at 10:41:18AM -0600, Henry Orosco wrote:
> > >
> > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > index 392f783..98923a8 100644
> > > --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> > > @@ -358,13 +358,16 @@ void i40iw_qp_add_qos(struct i40iw_sc_qp *qp)
> > > * @dev: sc device struct
> > > * @pd: sc pd ptr
> > > * @pd_id: pd_id for allocated pd
> > > + * @abi_ver: ABI version from user context, -1 if not valid
> > > */
> > > static void i40iw_sc_pd_init(struct i40iw_sc_dev *dev,
> > > struct i40iw_sc_pd *pd,
> > > - u16 pd_id)
> > > + u16 pd_id,
> > > + int abi_ver)
> >
> > No need for new line here
> >
>
> Not sure what you mean here.
>From code-style perspective "u16 pd_id," and "int abi_ver" can be on one line.
>
> > > {
> > > pd->size = sizeof(*pd);
> > > pd->pd_id = pd_id;
> > > + pd->abi_ver = abi_ver;
> > > pd->dev = dev;
> > > }
> > >
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-20 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 20:32 [PATCH] i40iw: Set 128B as the only supported RQ WQE size Henry Orosco
[not found] ` <20161219203227.86392-1-henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-20 10:47 ` Yuval Shaia
[not found] ` <20161220104720.GD7351-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-12-20 16:41 ` Henry Orosco
[not found] ` <20161220164118.GA91636-ZmvEvTIhtuUfyugFOqMDN/ooFf0ArEBIu+b9c/7xato@public.gmane.org>
2016-12-20 17:30 ` Yuval Shaia [this message]
2016-12-20 17:55 ` Henry Orosco
2016-12-20 11:24 ` Leon Romanovsky
[not found] ` <20161220112417.GV1074-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-20 12:44 ` Tung, Chien Tin
[not found] ` <748B799B6A00724488C603FD7E5E7EB94CBAEEA0-XfjTATA9Em864kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-12-20 13:42 ` Leon Romanovsky
[not found] ` <20161220134203.GW1074-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-20 14:46 ` Tung, Chien Tin
[not found] ` <748B799B6A00724488C603FD7E5E7EB94CBAFBBC-XfjTATA9Em864kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-12-20 20:02 ` Leon Romanovsky
[not found] ` <20161220200239.GA1074-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-21 0:04 ` Tung, Chien Tin
[not found] ` <748B799B6A00724488C603FD7E5E7EB94CBB12AF-XfjTATA9Em864kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-12-21 5:48 ` Leon Romanovsky
[not found] ` <20161221054805.GB1074-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-21 14:07 ` Tung, Chien Tin
[not found] ` <748B799B6A00724488C603FD7E5E7EB94CBB1BA8-XfjTATA9Em864kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-12-21 15:12 ` Leon Romanovsky
[not found] ` <20161221151250.GA18935-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2016-12-21 16:08 ` Tung, Chien Tin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220173044.GA3677@yuval-lap \
--to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=henry.orosco-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox