From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core 5/6] redhat/spec: clean up rsocket packaging Date: Thu, 22 Dec 2016 11:22:48 -0700 Message-ID: <20161222182248.GA5660@obsidianresearch.com> References: <20161221220840.36268-1-jarod@redhat.com> <20161221220840.36268-6-jarod@redhat.com> <140dc3aa-6088-c4cf-5a8a-1a0426f55cd3@redhat.com> <20161222173302.GA29518@obsidianresearch.com> <74c5651b-4125-0a7a-3184-d510814cdc0d@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <74c5651b-4125-0a7a-3184-d510814cdc0d-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford Cc: Jarod Wilson , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, Dec 22, 2016 at 01:15:55PM -0500, Doug Ledford wrote: > On 12/22/2016 12:33 PM, Jason Gunthorpe wrote: > > On Thu, Dec 22, 2016 at 02:17:52AM -0500, Jarod Wilson wrote: > >>> %files -n librdmacm > >>> %{_libdir}/librdmacm*.so.* > >>> -%{_libdir}/rsocket/*.so.* > >>> +%dir %{_libdir}/rsocket > >>> +%{_libdir}/rsocket/*.so > >> > >> Minor error here, should be rsocket/*.so* to pick up the symlinks too, at > >> least until they get neutered. > > I hand fixed this when taking the original series BTW... > > > FWIW, it would also be appropriate to put the LDPRELOAD library into > > librdmacm-utils.. > > I'm pretty sure the Fedora standards would want it in librsocket and not > in a -utils package. The -utils package should be executables and not > libraries. Not sure, don't see anything about preload libraries. This is not a link library, it is only executable via LD_PRELOAD, and it shouldn't result in any automatic RPM Provides either (ditto for all our plugins, I didn't check this). Ideally there would be a 'run under rsockets' helper tool that did the preload (ala fakeroot), and then it would be clear that the library is a private data file of the helper and not a system link library. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html