Re: [PATCH rdma-core] i40iw: Set 128B as the only supported RQ WQE size

[Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

On Thu, Dec 22, 2016 at 01:19:35PM -0500, Doug Ledford wrote:
> On 12/22/2016 12:13 PM, Leon Romanovsky wrote:
> > On Thu, Dec 22, 2016 at 11:53:20AM -0500, Doug Ledford wrote:
> >> On 12/19/2016 3:31 PM, Tatyana Nikolova wrote:
> >>> RQ WQE size other than 128B is not supported.
> >>> Correct RQ size calculation to use 128B only.
> >>>
> >>> Since this breaks ABI, add code to provide
> >>> compatibility with V4 kernel driver, i40iw.
> >>>
> >>> Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >>
> >> Thanks, applied.
> >
> > Hi Doug,
> >
> > Please can you clarify a process here?
> >
> > In previous discussions, you mentioned that the reason of not accepting
> > some code to rdma-core was because it is part of next kernel and we
> > patiently waited for release. This code is definitely not relevant for
> > current kernel, but you are already took it before we ever released first
> > version of rdma-core.
> >
> > So why are we waiting with libpvrdma and RoCE address handle?
>
> You're right, that was a mistake on my part.  I'll probably have to
> revert this patch, then reapply it for the next version since the 4.10
> kernel is the first one to provide the abi field to the user space library.

I assume that you are waiting for RHEL spec fixes to do actual release, but
maybe we should release it anyway now (replace rc3 with actual release)?

We are preparing fixes for Debian package which is not in perfect shape too,
and I don't want to let people wait till all these packages are finalized.

What do you think?

>
> >>
> >> --
> >> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >>     GPG Key ID: B826A3330E572FDD
> >>     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
> >>
> >
> >
> >
>
>
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>     GPG Key ID: B826A3330E572FDD
>     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
>




[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]