From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH rdma-next 5/9] IB/ipoib: rtnl_unlock can not come after free_netdev Date: Wed, 28 Dec 2016 14:05:12 +0200 Message-ID: <20161228120511.GB6237@yuval-lap> References: <20161227133911.14340-1-leon@kernel.org> <20161227133911.14340-6-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161227133911.14340-6-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Feras Daoud , Or Gerlitz , Erez Shitrit List-Id: linux-rdma@vger.kernel.org Reviewed-by: Yuval Shaia On Tue, Dec 27, 2016 at 03:39:07PM +0200, Leon Romanovsky wrote: > From: Feras Daoud > > The ipoib_vlan_add function calls rtnl_unlock after free_netdev, > rtnl_unlock not only releases the lock, but also calls netdev_run_todo. > The latter function browses the net_todo_list array and completes the > unregistration of all its net_device instances. If we call free_netdev > before rtnl_unlock, then netdev_run_todo call over the freed device causes > panic. > To fix, move rtnl_unlock call before free_netdev call. > > Fixes: 9baa0b036410 ("IB/ipoib: Add rtnl_link_ops support") > Cc: Or Gerlitz > Signed-off-by: Feras Daoud > Signed-off-by: Erez Shitrit > Signed-off-by: Leon Romanovsky > --- > drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c > index 9682183..d9dab4a 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c > @@ -168,11 +168,11 @@ int ipoib_vlan_add(struct net_device *pdev, unsigned short pkey) > out: > up_write(&ppriv->vlan_rwsem); > > + rtnl_unlock(); > + > if (result) > free_netdev(priv->dev); > > - rtnl_unlock(); > - > return result; > } > > -- > 2.10.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html