From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH rdma-next 9/9] IB/ipoib: Change list_del to list_del_init in the tx object Date: Wed, 28 Dec 2016 15:06:26 +0200 Message-ID: <20161228130625.GG6237@yuval-lap> References: <20161227133911.14340-1-leon@kernel.org> <20161227133911.14340-10-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161227133911.14340-10-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Feras Daoud , Erez Shitrit List-Id: linux-rdma@vger.kernel.org On Tue, Dec 27, 2016 at 03:39:11PM +0200, Leon Romanovsky wrote: > From: Feras Daoud > > Since ipoib_cm_tx_start function and ipoib_cm_tx_reap function > belong to different work queues, they can run in parallel. > In this case if ipoib_cm_tx_reap calls list_del and release the > lock, ipoib_cm_tx_start may acquire it and call list_del_init > on the already deleted object. > Changing list_del to list_del_init in ipoib_cm_tx_reap fixes the problem. > > Fixes: 839fcaba355a ("IPoIB: Connected mode experimental support") > Signed-off-by: Feras Daoud > Signed-off-by: Erez Shitrit > Reviewed-by: Alex Vesker > Signed-off-by: Leon Romanovsky > --- > drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c > index b6444b2..cc08379 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c > @@ -1392,7 +1392,7 @@ static void ipoib_cm_tx_reap(struct work_struct *work) > > while (!list_empty(&priv->cm.reap_list)) { > p = list_entry(priv->cm.reap_list.next, typeof(*p), list); > - list_del(&p->list); > + list_del_init(&p->list); > spin_unlock_irqrestore(&priv->lock, flags); > netif_tx_unlock_bh(dev); > ipoib_cm_tx_destroy(p); > -- Reviewed-by: Yuval Shaia > 2.10.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html