Re: [PATCH 1/1] ipoib: remove unnecessary returned value check

Re: [PATCH 1/1] ipoib: remove unnecessary returned value check

[Yanjun Zhu]

Any comment ?


On 2016/12/19 20:49, Zhu Yanjun wrote:
> In the function ipoib_set_dev_features, the returned value is always 0.
> As such, it is not necessary to check the returned value.
> This is not a bug. When I read the source code, I think it is not
> necessary to check it.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
>   drivers/infiniband/ulp/ipoib/ipoib.h      | 2 +-
>   drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 ++------
>   2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
> index da12717..f568064 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib.h
> +++ b/drivers/infiniband/ulp/ipoib/ipoib.h
> @@ -593,7 +593,7 @@ void ipoib_pkey_open(struct ipoib_dev_priv *priv);
>   void ipoib_drain_cq(struct net_device *dev);
>   
>   void ipoib_set_ethtool_ops(struct net_device *dev);
> -int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca);
> +void ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca);
>   
>   #define IPOIB_FLAGS_RC		0x80
>   #define IPOIB_FLAGS_UC		0x40
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 3ce0765..4e8e11e 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -1984,7 +1984,7 @@ int ipoib_add_pkey_attr(struct net_device *dev)
>   	return device_create_file(&dev->dev, &dev_attr_pkey);
>   }
>   
> -int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
> +void ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
>   {
>   	priv->hca_caps = hca->attrs.device_cap_flags;
>   
> @@ -1996,8 +1996,6 @@ int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
>   
>   		priv->dev->features |= priv->dev->hw_features;
>   	}
> -
> -	return 0;
>   }
>   
>   static struct net_device *ipoib_add_port(const char *format,
> @@ -2037,9 +2035,7 @@ static struct net_device *ipoib_add_port(const char *format,
>   		goto device_init_failed;
>   	}
>   
> -	result = ipoib_set_dev_features(priv, hca);
> -	if (result)
> -		goto device_init_failed;
> +	ipoib_set_dev_features(priv, hca);
>   
>   	/*
>   	 * Set the full membership bit, so that we join the right

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ipoib: remove unnecessary returned value check

[Yuval Shaia]

On Tue, Jan 03, 2017 at 10:34:32AM +0800, Yanjun Zhu wrote:
> Any comment ?

You will have to make change also to __ipoib_vlan_add

> 
> 
> On 2016/12/19 20:49, Zhu Yanjun wrote:
> >In the function ipoib_set_dev_features, the returned value is always 0.
> >As such, it is not necessary to check the returned value.
> >This is not a bug. When I read the source code, I think it is not
> >necessary to check it.

Please rephrase - omit the words "I think".

> >
> >Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> >---
> >  drivers/infiniband/ulp/ipoib/ipoib.h      | 2 +-
> >  drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 ++------
> >  2 files changed, 3 insertions(+), 7 deletions(-)
> >
> >diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
> >index da12717..f568064 100644
> >--- a/drivers/infiniband/ulp/ipoib/ipoib.h
> >+++ b/drivers/infiniband/ulp/ipoib/ipoib.h
> >@@ -593,7 +593,7 @@ void ipoib_pkey_open(struct ipoib_dev_priv *priv);
> >  void ipoib_drain_cq(struct net_device *dev);
> >  void ipoib_set_ethtool_ops(struct net_device *dev);
> >-int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca);
> >+void ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca);
> >  #define IPOIB_FLAGS_RC		0x80
> >  #define IPOIB_FLAGS_UC		0x40
> >diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> >index 3ce0765..4e8e11e 100644
> >--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> >+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> >@@ -1984,7 +1984,7 @@ int ipoib_add_pkey_attr(struct net_device *dev)
> >  	return device_create_file(&dev->dev, &dev_attr_pkey);
> >  }
> >-int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
> >+void ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
> >  {
> >  	priv->hca_caps = hca->attrs.device_cap_flags;
> >@@ -1996,8 +1996,6 @@ int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
> >  		priv->dev->features |= priv->dev->hw_features;
> >  	}
> >-
> >-	return 0;
> >  }
> >  static struct net_device *ipoib_add_port(const char *format,
> >@@ -2037,9 +2035,7 @@ static struct net_device *ipoib_add_port(const char *format,
> >  		goto device_init_failed;
> >  	}
> >-	result = ipoib_set_dev_features(priv, hca);
> >-	if (result)
> >-		goto device_init_failed;
> >+	ipoib_set_dev_features(priv, hca);
> >  	/*
> >  	 * Set the full membership bit, so that we join the right
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ipoib: remove unnecessary returned value check

[Yuval Shaia]

On Tue, Jan 03, 2017 at 10:34:32AM +0800, Yanjun Zhu wrote:
> Any comment ?

In addition to my previous mail, suggesting to change the commit header to
be more consistent.

IB/ipoib: Remove unnecessary returned value check

> 
> 
> On 2016/12/19 20:49, Zhu Yanjun wrote:
> >In the function ipoib_set_dev_features, the returned value is always 0.
> >As such, it is not necessary to check the returned value.
> >This is not a bug. When I read the source code, I think it is not
> >necessary to check it.
> >
> >Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> >---
> >  drivers/infiniband/ulp/ipoib/ipoib.h      | 2 +-
> >  drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 ++------
> >  2 files changed, 3 insertions(+), 7 deletions(-)
> >
> >diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
> >index da12717..f568064 100644
> >--- a/drivers/infiniband/ulp/ipoib/ipoib.h
> >+++ b/drivers/infiniband/ulp/ipoib/ipoib.h
> >@@ -593,7 +593,7 @@ void ipoib_pkey_open(struct ipoib_dev_priv *priv);
> >  void ipoib_drain_cq(struct net_device *dev);
> >  void ipoib_set_ethtool_ops(struct net_device *dev);
> >-int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca);
> >+void ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca);
> >  #define IPOIB_FLAGS_RC		0x80
> >  #define IPOIB_FLAGS_UC		0x40
> >diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> >index 3ce0765..4e8e11e 100644
> >--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> >+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> >@@ -1984,7 +1984,7 @@ int ipoib_add_pkey_attr(struct net_device *dev)
> >  	return device_create_file(&dev->dev, &dev_attr_pkey);
> >  }
> >-int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
> >+void ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
> >  {
> >  	priv->hca_caps = hca->attrs.device_cap_flags;
> >@@ -1996,8 +1996,6 @@ int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
> >  		priv->dev->features |= priv->dev->hw_features;
> >  	}
> >-
> >-	return 0;
> >  }
> >  static struct net_device *ipoib_add_port(const char *format,
> >@@ -2037,9 +2035,7 @@ static struct net_device *ipoib_add_port(const char *format,
> >  		goto device_init_failed;
> >  	}
> >-	result = ipoib_set_dev_features(priv, hca);
> >-	if (result)
> >-		goto device_init_failed;
> >+	ipoib_set_dev_features(priv, hca);
> >  	/*
> >  	 * Set the full membership bit, so that we join the right
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ipoib: remove unnecessary returned value check

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Tue, Jan 03, 2017 at 10:34:32AM +0800, Yanjun Zhu wrote:
> Any comment ?
>
>
> On 2016/12/19 20:49, Zhu Yanjun wrote:
> > In the function ipoib_set_dev_features, the returned value is always 0.
> > As such, it is not necessary to check the returned value.
> > This is not a bug. When I read the source code, I think it is not
> > necessary to check it.
> >
> > Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> >   drivers/infiniband/ulp/ipoib/ipoib.h      | 2 +-
> >   drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 ++------
> >   2 files changed, 3 insertions(+), 7 deletions(-)


➜  linux-rdma git:(rdma-next) grep -rI ipoib_set_dev_features drivers/infiniband/ulp/ipoib/*
drivers/infiniband/ulp/ipoib/ipoib.h:int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca);
drivers/infiniband/ulp/ipoib/ipoib_main.c:int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
drivers/infiniband/ulp/ipoib/ipoib_main.c:	result = ipoib_set_dev_features(priv, hca);
drivers/infiniband/ulp/ipoib/ipoib_vlan.c:	result = ipoib_set_dev_features(priv, ppriv->ca);

It lloks like, you frogot to update ipib_vlan.c

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]