* [patch] i40iw: fix some indenting in i40iw_sc_vsi_init()
@ 2017-01-07 6:30 Dan Carpenter
[not found] ` <20170107063042.GD26959-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Dan Carpenter @ 2017-01-07 6:30 UTC (permalink / raw)
To: Faisal Latif, Chien Tin Tung
Cc: Shiraz Saleem, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
The debug printk was indented more than it should have been and we
can remove an unnecessary line break.
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
index 98923a8cf86d..b9dc2c540946 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
@@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
i40iw_fill_qos_list(info->params->qs_handle_list);
for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
- vsi->qos[i].qs_handle =
- info->params->qs_handle_list[i];
- i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
+ vsi->qos[i].qs_handle = info->params->qs_handle_list[i];
+ i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
+ vsi->qos[i].qs_handle);
spin_lock_init(&vsi->qos[i].lock);
INIT_LIST_HEAD(&vsi->qos[i].qplist);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [patch] i40iw: fix some indenting in i40iw_sc_vsi_init()
[not found] ` <20170107063042.GD26959-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2017-01-07 17:34 ` Yuval Shaia
2017-01-09 19:41 ` Shiraz Saleem
1 sibling, 0 replies; 7+ messages in thread
From: Yuval Shaia @ 2017-01-07 17:34 UTC (permalink / raw)
To: Dan Carpenter
Cc: Faisal Latif, Chien Tin Tung, Shiraz Saleem, Doug Ledford,
Sean Hefty, Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Sat, Jan 07, 2017 at 09:30:42AM +0300, Dan Carpenter wrote:
> The debug printk was indented more than it should have been and we
> can remove an unnecessary line break.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> index 98923a8cf86d..b9dc2c540946 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> @@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
> i40iw_fill_qos_list(info->params->qs_handle_list);
>
> for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
> - vsi->qos[i].qs_handle =
> - info->params->qs_handle_list[i];
> - i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
> + vsi->qos[i].qs_handle = info->params->qs_handle_list[i];
> + i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
> + vsi->qos[i].qs_handle);
Nice catch :)
FWIW:
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> spin_lock_init(&vsi->qos[i].lock);
> INIT_LIST_HEAD(&vsi->qos[i].qplist);
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] i40iw: fix some indenting in i40iw_sc_vsi_init()
[not found] ` <20170107063042.GD26959-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2017-01-07 17:34 ` Yuval Shaia
@ 2017-01-09 19:41 ` Shiraz Saleem
[not found] ` <20170109194127.GA42156-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
1 sibling, 1 reply; 7+ messages in thread
From: Shiraz Saleem @ 2017-01-09 19:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: Faisal Latif, Chien Tin Tung, Doug Ledford, Sean Hefty,
Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Sat, Jan 07, 2017 at 09:30:42AM +0300, Dan Carpenter wrote:
> The debug printk was indented more than it should have been and we
> can remove an unnecessary line break.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> index 98923a8cf86d..b9dc2c540946 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> @@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
> i40iw_fill_qos_list(info->params->qs_handle_list);
>
> for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
> - vsi->qos[i].qs_handle =
> - info->params->qs_handle_list[i];
> - i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
> + vsi->qos[i].qs_handle = info->params->qs_handle_list[i];
It appears there is a tab char after the =. Rather than a space.
> + i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
> + vsi->qos[i].qs_handle);
> spin_lock_init(&vsi->qos[i].lock);
> INIT_LIST_HEAD(&vsi->qos[i].qplist);
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [patch v2] i40iw: fix some indenting in i40iw_sc_vsi_init()
[not found] ` <20170109194127.GA42156-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
@ 2017-01-09 20:12 ` Dan Carpenter
2017-01-09 20:31 ` Shiraz Saleem
2017-01-09 20:40 ` Yuval Shaia
0 siblings, 2 replies; 7+ messages in thread
From: Dan Carpenter @ 2017-01-09 20:12 UTC (permalink / raw)
To: Faisal Latif, Chien Tin Tung, Shiraz Saleem
Cc: Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
The debug printk was indented more than it should have been and we
can remove an unnecessary line break.
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
v2: I accidentally had a tab instead of a space.
diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
index 98923a8cf86d..b9dc2c540946 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
@@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
i40iw_fill_qos_list(info->params->qs_handle_list);
for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
- vsi->qos[i].qs_handle =
- info->params->qs_handle_list[i];
- i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
+ vsi->qos[i].qs_handle = info->params->qs_handle_list[i];
+ i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
+ vsi->qos[i].qs_handle);
spin_lock_init(&vsi->qos[i].lock);
INIT_LIST_HEAD(&vsi->qos[i].qplist);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [patch v2] i40iw: fix some indenting in i40iw_sc_vsi_init()
2017-01-09 20:12 ` [patch v2] " Dan Carpenter
@ 2017-01-09 20:31 ` Shiraz Saleem
[not found] ` <20170109203112.GA42952-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
2017-01-09 20:40 ` Yuval Shaia
1 sibling, 1 reply; 7+ messages in thread
From: Shiraz Saleem @ 2017-01-09 20:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Faisal Latif, Chien Tin Tung, Doug Ledford, Sean Hefty,
Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Mon, Jan 09, 2017 at 11:12:16PM +0300, Dan Carpenter wrote:
> The debug printk was indented more than it should have been and we
> can remove an unnecessary line break.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> v2: I accidentally had a tab instead of a space.
Thank you for the patch Dan.
Acked-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch v2] i40iw: fix some indenting in i40iw_sc_vsi_init()
2017-01-09 20:12 ` [patch v2] " Dan Carpenter
2017-01-09 20:31 ` Shiraz Saleem
@ 2017-01-09 20:40 ` Yuval Shaia
1 sibling, 0 replies; 7+ messages in thread
From: Yuval Shaia @ 2017-01-09 20:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Faisal Latif, Chien Tin Tung, Shiraz Saleem, Doug Ledford,
Sean Hefty, Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Mon, Jan 09, 2017 at 11:12:16PM +0300, Dan Carpenter wrote:
> The debug printk was indented more than it should have been and we
> can remove an unnecessary line break.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> v2: I accidentally had a tab instead of a space.
Also for this one:
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> index 98923a8cf86d..b9dc2c540946 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> @@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
> i40iw_fill_qos_list(info->params->qs_handle_list);
>
> for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
> - vsi->qos[i].qs_handle =
> - info->params->qs_handle_list[i];
> - i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
> + vsi->qos[i].qs_handle = info->params->qs_handle_list[i];
> + i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
> + vsi->qos[i].qs_handle);
> spin_lock_init(&vsi->qos[i].lock);
> INIT_LIST_HEAD(&vsi->qos[i].qplist);
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch v2] i40iw: fix some indenting in i40iw_sc_vsi_init()
[not found] ` <20170109203112.GA42952-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
@ 2017-01-24 21:29 ` Doug Ledford
0 siblings, 0 replies; 7+ messages in thread
From: Doug Ledford @ 2017-01-24 21:29 UTC (permalink / raw)
To: Shiraz Saleem, Dan Carpenter
Cc: Faisal Latif, Chien Tin Tung, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
On Mon, 2017-01-09 at 14:31 -0600, Shiraz Saleem wrote:
> On Mon, Jan 09, 2017 at 11:12:16PM +0300, Dan Carpenter wrote:
> >
> > The debug printk was indented more than it should have been and we
> > can remove an unnecessary line break.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> > v2: I accidentally had a tab instead of a space.
>
> Thank you for the patch Dan.
>
> Acked-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Applied v2 of the patch, thanks.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-24 21:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-07 6:30 [patch] i40iw: fix some indenting in i40iw_sc_vsi_init() Dan Carpenter
[not found] ` <20170107063042.GD26959-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2017-01-07 17:34 ` Yuval Shaia
2017-01-09 19:41 ` Shiraz Saleem
[not found] ` <20170109194127.GA42156-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
2017-01-09 20:12 ` [patch v2] " Dan Carpenter
2017-01-09 20:31 ` Shiraz Saleem
[not found] ` <20170109203112.GA42952-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
2017-01-24 21:29 ` Doug Ledford
2017-01-09 20:40 ` Yuval Shaia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox