From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core] rdma: Handle uninitialized data for ibv_cmd_modify_qp Date: Tue, 10 Jan 2017 09:09:12 -0700 Message-ID: <20170110160912.GA15493@obsidianresearch.com> References: <1484060645-27997-1-git-send-email-yishaih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1484060645-27997-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yishai Hadas Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Jan 10, 2017 at 05:04:05PM +0200, Yishai Hadas wrote: > Instead of checking per field whether wasn't set then use explicit = 0, > go over the providers and initialize their input command by using = {}. NAK, you have to retain the compares that was the entire point. The issue is that the *user* input is uninitialized. All you can drop is the set to zero path because the caller inited the kernel struct. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html