From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH V1 rdma-core] rdma: Handle uninitialized data for ibv_cmd_modify_qp
Date: Tue, 10 Jan 2017 21:15:27 +0200 [thread overview]
Message-ID: <20170110191527.GU7218@mtr-leonro.local> (raw)
In-Reply-To: <1484069070-17174-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]
On Tue, Jan 10, 2017 at 07:24:30PM +0200, Yishai Hadas wrote:
> Instead of checking per field whether wasn't set then use explicit = 0,
> go over the providers and initialize their input command by using = {}.
>
> This comes as a pre-patch before introducing the ibv_cmd_modify_qp_ex
> which will do the same.
>
> The above drops the need to add an extra 'zeroing' code each time
> when a new field is introduced.
>
> This improves commit 77fbb25e4c2a1f99d812752f85a28978ece32fe0 as pointed
> above.
>
> Signed-off-by: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> libibverbs/cmd.c | 47 +---------------------------------------
> providers/cxgb3/verbs.c | 2 +-
> providers/cxgb4/qp.c | 2 +-
> providers/cxgb4/verbs.c | 2 +-
> providers/hfi1verbs/verbs.c | 2 +-
> providers/hns/hns_roce_u_hw_v1.c | 2 +-
> providers/i40iw/i40iw_uverbs.c | 2 +-
> providers/ipathverbs/verbs.c | 2 +-
> providers/mlx4/verbs.c | 2 +-
> providers/mlx5/verbs.c | 2 +-
> providers/mthca/verbs.c | 2 +-
> providers/nes/nes_uverbs.c | 2 +-
> providers/ocrdma/ocrdma_verbs.c | 2 +-
> providers/qedr/qelr_verbs.c | 2 +-
> providers/rxe/rxe.c | 2 +-
> 15 files changed, 15 insertions(+), 60 deletions(-)
>
Thanks,
Acked-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-01-10 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 17:24 [PATCH V1 rdma-core] rdma: Handle uninitialized data for ibv_cmd_modify_qp Yishai Hadas
[not found] ` <1484069070-17174-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-10 19:15 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110191527.GU7218@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).