From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 2/9] Move dma_ops from archdata into struct device Date: Wed, 11 Jan 2017 07:48:03 +0100 Message-ID: <20170111064803.GB26893@kroah.com> References: <20170111005648.14988-1-bart.vanassche@sandisk.com> <20170111005648.14988-3-bart.vanassche@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170111005648.14988-3-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Bart Van Assche Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Rich Felker , linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Aurelien Jacquiot , Catalin Marinas , Will Deacon , Muli Ben-Yehuda , David Howells , Max Filippov , "H . Peter Anvin" , sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Thomas Gleixner , Hans-Christian Egtvedt , Jonas Bonn , linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jesper Nilsson , linux-am33-list-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-c6x-dev-jPsnJVOj+W6hPH1hqNUYSQ@public.gmane.org, Yoshinori Sato , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-hexagon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Helge Deller , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, "James E . J . Bottomley" , Doug Ledford List-Id: linux-rdma@vger.kernel.org On Tue, Jan 10, 2017 at 04:56:41PM -0800, Bart Van Assche wrote: > Several RDMA drivers, e.g. drivers/infiniband/hw/qib, use the CPU to > transfer data between memory and PCIe adapter. Because of performance > reasons it is important that the CPU cache is not flushed when such > drivers transfer data. Make this possible by allowing these drivers to > override the dma_map_ops pointer. Additionally, introduce the function > set_dma_ops() that will be used by a later patch in this series. When you say things like "additionally", that's a huge flag that this needs to be split up into multiple patches. No need to add set_dma_ops() here in this patch. And I'd argue that it should be dma_ops_set(), and dma_ops_get(), just to keep the namespace sane, but that's probably a different set of patches... thanks, greg k-h