From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [bug report] i40iw: add main, hdr, status
Date: Tue, 17 Jan 2017 16:58:50 +0300 [thread overview]
Message-ID: <20170117135850.GB6353@mwanda> (raw)
Hello Faisal Latif,
The patch 8e06af711bf2: "i40iw: add main, hdr, status" from Jan 20,
2016, leads to the following static checker warning:
drivers/infiniband/hw/i40iw/i40iw_main.c:606 i40iw_create_cqp()
error: uninitialized symbol 'maj_err'.
drivers/infiniband/hw/i40iw/i40iw_main.c
599 status = dev->cqp_ops->cqp_init(dev->cqp, &cqp_init_info);
600 if (status) {
601 i40iw_pr_err("cqp init status %d\n", status);
602 goto exit;
603 }
604 status = dev->cqp_ops->cqp_create(dev->cqp, &maj_err, &min_err);
605 if (status) {
606 i40iw_pr_err("cqp create status %d maj_err %d min_err %d\n",
607 status, maj_err, min_err);
Not all error paths in i40iw_sc_cqp_create() initialized maj_err and
min_err. Can't we just delete this printk?
608 goto exit;
609 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2017-01-17 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 13:58 Dan Carpenter [this message]
2017-01-17 18:52 ` [bug report] i40iw: add main, hdr, status Shiraz Saleem
[not found] ` <20170117185247.GA63212-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
2017-01-18 11:24 ` Yuval Shaia
[not found] ` <20170118112408.GC7544-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2017-01-18 20:01 ` Saleem, Shiraz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117135850.GB6353@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox