From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [bug report] i40iw: add main, hdr, status Date: Tue, 17 Jan 2017 16:58:50 +0300 Message-ID: <20170117135850.GB6353@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org Hello Faisal Latif, The patch 8e06af711bf2: "i40iw: add main, hdr, status" from Jan 20, 2016, leads to the following static checker warning: drivers/infiniband/hw/i40iw/i40iw_main.c:606 i40iw_create_cqp() error: uninitialized symbol 'maj_err'. drivers/infiniband/hw/i40iw/i40iw_main.c 599 status = dev->cqp_ops->cqp_init(dev->cqp, &cqp_init_info); 600 if (status) { 601 i40iw_pr_err("cqp init status %d\n", status); 602 goto exit; 603 } 604 status = dev->cqp_ops->cqp_create(dev->cqp, &maj_err, &min_err); 605 if (status) { 606 i40iw_pr_err("cqp create status %d maj_err %d min_err %d\n", 607 status, maj_err, min_err); Not all error paths in i40iw_sc_cqp_create() initialized maj_err and min_err. Can't we just delete this printk? 608 goto exit; 609 } regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html