Re: [PATCH RFC rdma-core 0/3] Common Provider Debug Printing

[Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]

On Tue, Jan 17, 2017 at 01:45:31PM -0600, Tatyana Nikolova wrote:
> Similar debug printing functionality is
> refactored to reduce code duplication in two
> rdma-core providers. Please review and comment
> whether the proposed debug printing approach
> should be adopted by the rdma-core providers.
>
> For more information about the issue this patch
> series addresses, see the email thread titled
> "[PATCH V2 08/10] i40iw: Control debug error prints using env variable"
>
> Tatyana Nikolova (3):
>   util: Add common code for provider debug
>   mlx5: Use common provider debug macros
>   qedr: Use common provider debug macros
>
>  buildlib/rdma_functions.cmake |   2 +-
>  providers/mlx5/buf.c          |  18 ++---
>  providers/mlx5/cq.c           |   6 +-
>  providers/mlx5/mlx5.c         |  51 ++++---------
>  providers/mlx5/mlx5.h         |  27 +------
>  providers/mlx5/qp.c           |  24 +++---
>  providers/mlx5/verbs.c        |  48 ++++++------
>  providers/qedr/qelr.h         |  57 +-------------
>  providers/qedr/qelr_main.c    |  68 +++--------------
>  providers/qedr/qelr_verbs.c   | 168 ++++++++++++++++++++++++------------------
>  util/CMakeLists.txt           |   8 ++
>  util/dbg.c                    |  83 +++++++++++++++++++++
>  util/dbg.h                    |  95 ++++++++++++++++++++++++
>  13 files changed, 358 insertions(+), 297 deletions(-)
>  create mode 100644 util/dbg.c
>  create mode 100644 util/dbg.h

Thanks Tatyana,

There is need to add new file to Documentation/ with description of
these common environmental variables.

And can you please add patch for i40iw debug prints to the final version too?

>
> --
> 1.8.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]