Re: [PATCH RFC rdma-core 3/3] qedr: Use common provider debug macros

[Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2234 bytes --]

On Wed, Jan 18, 2017 at 09:52:20AM +0000, Amrani, Ram wrote:
> > Replace qedr specific debug macros with
> > common provider macros.
> >
> > Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
>
> Thanks for doing this Tatyana!
>
> > @@ -254,7 +251,8 @@ struct ibv_cq *qelr_create_cq(struct ibv_context *context, int cqe,
> >  			       &cq->ibv_cq, &cmd.ibv_cmd, sizeof(cmd),
> >  			       &resp.ibv_resp, sizeof(resp));
> >  	if (rc) {
> > -		DP_ERR(cxt->dbg_fp, "create cq: failed with rc = %d\n", rc);
> > +		LOG_DBG_FLUSH(cxt->dbg_fp, VERBS_DBG_MASK_ALL, VERBS_DBG_LEVEL_VERBOSE,
> > +				"create cq: failed with rc = %d\n", rc);
> >  		goto err_1;
> >  	}
> >
>
> I'm OK with replacing DP_VERBOSE with LOG_DBG_FLUSH(,..., VERBS_DBG_LEVEL_VERBOSE, ...)
> as these prints should be printed only if enabled. In multiple locations, however, I see that
> DP_ERR is replaced as DP_VERBOSE. But whenever a DP_ERR appears the output is expected to
> show regardless of verbosity level.
>
> > @@ -1208,7 +1212,7 @@ int qelr_post_send(struct ibv_qp *ib_qp, struct ibv_send_wr *wr,
> >  			qp->wqe_wr_id[qp->sq.prod].wqe_size = swqe->wqe_size;
> >  			qp->prev_wqe_size = swqe->wqe_size;
> >  			qp->wqe_wr_id[qp->sq.prod].bytes_len = swqe->length;
> > -			FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ,
> > +			LOG_DBG_FLUSH(cxt->dbg_fp, VERBS_DBG_MASK_CQ, VERBS_DBG_LEVEL_VERBOSE,
> >  				      "SEND w/ IMM length = %d imm data=%x\n",
> >  				      swqe->length, wr->imm_data);
> >  			break;
>
> Please delete _all_ occurrences of FP_DP_VERVBOSE
> They will flood the debug buffer and will render it unusable.
> (they were disabled by default from being even compiled).
> Alternatively I can delete them myself, but if so then don't replace them with anything.

Ram,
Please do, so I'll be able to apply that patch immediately and won't need to
wait till you Ack on Tatyana's series, especially in regards her other
patch which fixed compilation error.

Thanks.

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]